Skip to content

feat(identity): reconcile the identity provider from one declared file (ARBORA-DEPLOY-R603) - #664

Merged
Knucklessg1 merged 4 commits into
mainfrom
untangle/deploy-config
Nov 16, 2026
Merged

Knucklessg1 merged 4 commits into
mainfrom
untangle/deploy-config

Conversation

@Knucklessg1

@Knucklessg1 Knucklessg1 commented Nov 7, 2026 •

Copy link
Copy Markdown
Member

What

arbora identity reconcile --file <identity.yml> [--plan|--check] reads one closed-schema identity file (realm settings, roles with composites, groups, client scopes, dynamic client registration trusted hosts, public, confidential and service clients, service accounts and human accounts). It plans the difference, applies it idempotently, plans again to prove convergence, and reports drift. ARBORA-DEPLOY-R603: identity and application single sign-on provisioning is one declarative reconcile.

Why

Deployments provisioned the identity provider with several per-purpose scripts. One declared file and one command replace them, with a drift check from the same file.

Impact

  • It only creates, updates and adds. It never deletes, and it does not rewrite a native client that already matches.
  • Realm settings cannot change how people sign in: flow bindings (any *Flow key), authentication flows, authenticator config, identity providers and their mappers, components and required actions are refused. So are the collections the schema declares itself (roles, groups, scopes, clients, users).
  • Declared clients render only the fields the file states, so a file exported from a live realm plans zero changes.
  • Client secrets go to the declared secret store only when they differ. The file holds references, never secret values.
  • The command reuses the existing realm admin adapter and client representation of the client contract (ARBORA-IDENTITY-R030.4).

Verification

tests/deployment/test_identity_reconcile.py covers idempotence and drift, matching native clients, no deletes, forbidden roles, duplicate emails, the closed schema including the refused settings keys, and the file loader. The full suite and pre-commit run --all-files pass locally on the head commit.

🤖 Generated with Claude Code

@Knucklessg1
Knucklessg1 enabled auto-merge (squash) November 7, 2026 05:23
@Knucklessg1
Knucklessg1 force-pushed the untangle/deploy-config branch 2 times, most recently from bf93968 to e5fa8f5 Compare November 16, 2026 18:03
Knucklessg1 and others added 4 commits November 16, 2026 12:39
`arbora identity reconcile --file <identity.yml>` reads a closed-schema file
(realm settings, roles with composites, groups, client scopes, dynamic client
registration trusted hosts, public/confidential/service clients, service
accounts, human accounts), plans the difference, applies it idempotently,
re-plans to prove convergence, and exposes `--plan` and `--check` (drift).
It only creates, updates and adds; it never deletes. A native client that
already matches is not written. Client secrets publish to the declared secret
store only when they differ. This replaces the environment's per-purpose
reconcile scripts.

Spec: ARBORA-DEPLOY-R603
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Post-logout URIs, base URL, direct-access grants and the client name are
written only when declared, so a file exported from a live realm plans zero
changes against it. PKCE "none" declares that PKCE is not required.

Spec: ARBORA-DEPLOY-R603
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…e renamed SDK

The declared file's settings map was written to the realm as given, so a
file could rebind a login flow, add or replace an identity provider, or
write roles, clients and users past their own validation. Settings now
refuse every flow binding (any key ending in Flow), authentication flows,
authenticator config, identity providers and their mappers, components,
required actions and the collections the schema declares itself. How
people sign in is never changed by this command.

The secret-store sink and the broad admin transport imported the
connector SDK under its old package name, which is not installed; they
now import scion_sdk like the rest of the identity module.

Verified with the reconcile tests, including new closed-schema cases for
the refused settings keys.

Spec: ARBORA-DEPLOY-R603
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The locked-environment type check read the fake identity provider's
components table as a collection of strings and refused indexing its
config. The table is now annotated as a mapping of component ids to
component representations, like the fake's other tables. Test-only;
the assertions are unchanged.

Verified with the locked mypy hook over all files.

Spec: ARBORA-DEPLOY-R603
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@Knucklessg1
Knucklessg1 force-pushed the untangle/deploy-config branch from e5fa8f5 to 84aa8e5 Compare November 16, 2026 18:41
@Knucklessg1
Knucklessg1 merged commit 59e6aaa into main Nov 16, 2026
7 checks passed
@Knucklessg1
Knucklessg1 deleted the untangle/deploy-config branch November 16, 2026 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant