refactor: consolidate record header access, drop dead code - #64
Merged
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
Contributor
Benchmark Results (Julia v1)Time benchmarks
Memory benchmarks
|
- record_size/get_record_type/next_record_offset in one place; the Header struct and six hand-rolled copies of the chain-walk arithmetic are gone - find_vdr/keys walk the VDR chains through OffsetsIterator - delete flatten_field_types, the runtime-n read_be/read_be_i, and the collection check_record_type — all uncalled - julia_type no longer builds a StaticString type its only caller discards
Beforerr
force-pushed
the
push-xqxuvrvqmkny
branch
from
August 31, 2026 09:14
403be90 to
c277bc3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
struct and six hand-rolled copies of the chain-walk arithmetic are gone
collection check_record_type — all uncalled