feat: support sparse records (pad and previous-record) - #48
Open
Beforerr wants to merge 1 commit into
Open
Conversation
sRecords was parsed but unused; reading a sparse variable crashed with a TypeError on the first virtual record. Add a sparse read path mirroring cdflib semantics: pad sparse fills virtual records with the VDR pad value (or the NASA default pad, which differs from ISTP FILLVAL), prev sparse repeats the last record of the preceding physical block. Pad values are read/filled in file encoding so the final byte swap covers them together with physical data. Fixture generated by test/make_sparse_cdf.py (cdflib writer); note cdflib's own reader pads only the first element of multi-element records — we fill the whole record per the CDF IFD. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Contributor
Benchmark Results (Julia v1)Time benchmarks
Memory benchmarks
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sRecords was parsed but unused; reading a sparse variable crashed with a
TypeError on the first virtual record. Add a sparse read path mirroring
cdflib semantics: pad sparse fills virtual records with the VDR pad value
(or the NASA default pad, which differs from ISTP FILLVAL), prev sparse
repeats the last record of the preceding physical block.
Pad values are read/filled in file encoding so the final byte swap covers
them together with physical data. Fixture generated by test/make_sparse_cdf.py
(cdflib writer); note cdflib's own reader pads only the first element of
multi-element records — we fill the whole record per the CDF IFD.
Co-Authored-By: Claude Fable 5 noreply@anthropic.com