Repository navigation
Remove preview CLI aliases and enforce canonical commands - #168
Merged
Merged
Conversation
Complete the approved VN5 canonical-only surface while preserving MCP names and frozen historical evaluation inputs. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The evaluator still prompts models to use removed cpu, and the help gate can terminate prematurely under PowerShell native-error handling.
Review effort: Balanced
Findings: 2
Open (2)
What changed in this PR
Removes preview CLI aliases, enforcing the canonical 16-command surface while preserving MCP contracts.
Changes:
- Removes 12 hidden aliases and rejects unknown commands with usage errors.
- Migrates tests, documentation, evaluation, and analysis allowlists.
- Updates the prepared EP1 v3 skill-manifest identity.
| File | Description |
|---|---|
src/Filtrace/Cli/TraceCommands.cs |
Removes alias handlers. |
src/Filtrace/Cli/CliApp.cs |
Adds unknown-command guard. |
src/Filtrace/Program.cs |
Removes obsolete commentary. |
tests/Filtrace.Cli.Tests/CliAppTests.cs |
Tests canonical commands and alias rejection. |
tools/Test-CliHelp.ps1 |
Enforces help and rejection contracts. |
tools/Test-FiltraceAnalysis.ps1 |
Tests retired-operation rejection. |
tools/Test-AgentEval.ps1 |
Updates evaluator contract coverage. |
eval/Invoke-AgentEval.ps1 |
Restricts mediation to canonical commands. |
eval/Get-OperationName.ps1 |
Removes alias normalization. |
eval/README.md |
Updates the example command. |
eval/protocols/ep1-ready-capture-v3.json |
Refreshes skill-manifest hashes. |
.agents/skills/filtrace/scripts/Invoke-FiltraceAnalysis.ps1 |
Removes aliases from analysis allowlists. |
README.md |
Removes migration guidance. |
docs/workflow.md |
Updates canonical workflow terminology. |
docs/design.md |
Records the canonical-only surface. |
docs/roadmap.md |
Marks VN5 complete. |
docs/filtrace-etl-trimming.md |
Replaces aliases in examples. |
AGENTS.md |
Updates the CLI validation description. |
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
Complete the approved VN5 canonical-only CLI surface.
alloc,clean,convert,cpu,diskio,exceptions,gcstats,heatmap,jitstats,lines,threadpool, andthreadtime.trace_*MCP tool name.No package release, version tag, MCP rename, trace-reader change, or regeneration of raw captures.
Validation
The initial Debug fixture run found old unmarked ETLX caches in generated test output. Only those caches were explicitly cleaned with the local CLI before rerunning; raw fixtures were not changed.
One parallel analysis-contract attempt encountered a native-host startup/version failure; direct version probes and the unchanged contract's serial rerun passed.
Review scope
Please keep review bounded to obvious functional mistakes, command/option regressions, stale active references, and failure/side-effect behavior. No speculative redesign or additional release work.