Skip to content

feat: configure map control persistence - #141

Closed
feenx wants to merge 1 commit into
Iternio-Planning-AB:masterfrom
feenx:chris/codex-button-persistence
Closed

feenx wants to merge 1 commit into
Iternio-Planning-AB:masterfrom
feenx:chris/codex-button-persistence

Conversation

@feenx

@feenx feenx commented Oct 19, 2026

Copy link
Copy Markdown

Summary

  • Add Android map/pan button flags so selected controls can remain visible while other controls auto-hide.
  • Expose CarPlay navigation-bar and map-button group auto-hide settings, preserving current defaults and panel ownership.

Motivation

Usage

mapTemplate.setMapButtons([
  { type: 'custom', image: recenterImage, onPress: recenter, flags: Flag.Persistent },
  { type: 'custom', image: zoomInImage, onPress: zoomIn },
]);

// CarPlay, at MapTemplate creation; both default to true.
new MapTemplate({
  ...config,
  automaticallyHidesNavigationBar: false,
  hidesButtonsWithNavigationBar: false,
});
  • Android flags apply per button. CarPlay settings apply to whole groups; Android flags are ignored there.

Screenshots / recordings

  • Pending DHU / CarPlay validation. This remains a draft; native app builds and car-surface captures have not been run.

Test plan

  • 38 regression tests pass, including extracted Kotlin parser and Swift visibility behavior with platform stubs; these are not full native app tests.
  • New tests detect missing persistence on pristine 0.9.1.
  • JavaScript/package output build and Nitro regeneration pass.
  • Android Auto DHU / real head unit: idle timeout, mixed persistent/auto-hide actions, pan and recenter.
  • CarPlay simulator / real head unit: visibility settings, panel dismissal and pan transitions; attach captures.

Checklist

  • yarn lint:auto-play and yarn typecheck:auto-play pass.
  • Native configuration uses NitroModules; regenerated bindings are committed.
  • Package version is unchanged.
  • Consumer README and contributor template documentation are updated.

🤖 Generated with Codex (GPT-6)

@feenx feenx closed this Oct 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant