Do not generate Peras certificates if they would be larger than maximum block size - #2187
Draft
nbacquey wants to merge 6 commits into
Draft
Do not generate Peras certificates if they would be larger than maximum block size#2187nbacquey wants to merge 6 commits into
nbacquey wants to merge 6 commits into
Conversation
Co-authored-by: Agustin Mista <agustin.mista@tweag.io> Co-authored-by: Thomas BAGREL <thomas.bagrel@tweag.io> Co-authored-by: Nicolas BACQUEY <nicolas.bacquey@tweag.io>
nbacquey
force-pushed
the
nb/no-big-peras-cert
branch
from
August 6, 2026 18:49
eeb00af to
4b1a081
Compare
agustinmista
force-pushed
the
peras/the-big-pr
branch
22 times, most recently
from
August 11, 2026 16:57
dab1c96 to
cda472b
Compare
agustinmista
force-pushed
the
peras/the-big-pr
branch
22 times, most recently
from
August 19, 2026 07:22
505e2bc to
55fb785
Compare
agustinmista
force-pushed
the
peras/the-big-pr
branch
8 times, most recently
from
August 21, 2026 11:49
de55a3c to
6cb87c5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If we generated a certificate that is too large to fit in a block body, we would have an error in the future if we choose to include it in a block.
Instead, we now consider the certificate forging to have failed.