Repository navigation
fix: stop retrying 429 responses - #10
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
internal/ipgeolocation/errors.go:IsRetryableno longer includes 429; 500, 502, 503 and 504 are still retried.README.md,docs/configuration.md,docs/troubleshooting.md): retries cover 5xx and network failures; 4xx, including 429, return at once.The API has no per-second rate limits. A 429 means no credits are left (the free plan's daily credits, or a paid plan's credits with overage off or at its cap), so a retry seconds later cannot succeed; it only delays the error. Source: the status table on https://ipgeolocation.io/documentation/ip-location-api.html.
Tests:
go test ./...passes (the retryable table now expects 429 = false).