Skip to content

Add Bundler cooldown#22555

Merged
MikeMcQuaid merged 1 commit into
mainfrom
ruby-bundler-cooldown
Jun 5, 2026
Merged

Add Bundler cooldown#22555
MikeMcQuaid merged 1 commit into
mainfrom
ruby-bundler-cooldown

Conversation

@MikeMcQuaid
Copy link
Copy Markdown
Member

  • Set BUNDLE_COOLDOWN in common_stage_test_env so Bundler uses the same RubyGems release cooldown during staged formula work
  • Centralise cooldown days for npm, PyPI and livecheck paths so the policy stays consistent

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them? Performance claims (e.g. "this is faster") must include Hyperfine benchmarks.
  • Have you written new tests (excluding integration tests) for your changes? Here's an example.
  • Have you successfully run brew lgtm (style, typechecking and tests) with your changes locally?

  • AI was used to generate or assist with generating this PR.

OpenAI Codex 5.5 xhigh with local review and testing.


Copilot AI review requested due to automatic review settings June 5, 2026 19:10
@MikeMcQuaid MikeMcQuaid enabled auto-merge June 5, 2026 19:10
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR introduces a centralized “release cooldown” policy and applies it across multiple dependency/update paths, including setting a Bundler cooldown in staged formula environments.

Changes:

  • Add Homebrew::RELEASE_COOLDOWN_DAYS / Homebrew::RELEASE_COOLDOWN_SECONDS in a new release_cooldown.rb.
  • Use the centralized cooldown in PyPI (--uploaded-prior-to), npm (--min-release-age), and brew bump livecheck cooldown logic.
  • Export BUNDLE_COOLDOWN from Formula#common_stage_test_env and add a spec covering it.

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
Library/Homebrew/release_cooldown.rb Adds centralized cooldown constants (days + derived seconds).
Library/Homebrew/utils/pypi.rb Uses centralized cooldown seconds for pip’s --uploaded-prior-to.
Library/Homebrew/formula.rb Uses centralized cooldown for std_pip_args and exports BUNDLE_COOLDOWN in staged/test env.
Library/Homebrew/language/node.rb Uses centralized cooldown days for npm --min-release-age.
Library/Homebrew/dev-cmd/bump.rb Replaces internal cooldown constant with centralized cooldown days.
Library/Homebrew/formula_installer.rb Adds a new require "release_cooldown" (currently unused).
Library/Homebrew/test/formula_spec.rb Adds a spec ensuring BUNDLE_COOLDOWN is set.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread Library/Homebrew/formula_installer.rb Outdated
Comment thread Library/Homebrew/test/formula_spec.rb
- Set `BUNDLE_COOLDOWN` in `common_stage_test_env` so Bundler uses
  the same RubyGems release cooldown during staged formula work
- Centralise cooldown days for npm, PyPI and livecheck paths so the
  policy stays consistent
@MikeMcQuaid MikeMcQuaid force-pushed the ruby-bundler-cooldown branch from a82dcc6 to e7bb127 Compare June 5, 2026 19:23
@github-code-quality
Copy link
Copy Markdown

github-code-quality Bot commented Jun 5, 2026

Code Coverage Overview

Languages: Ruby

Ruby / code-coverage/simplecov

The overall coverage in the branch remains at 78%, unchanged from the branch.

Show a code coverage summary of the most impacted files.
File c6a08de e7bb127 +/-
services/system/systemctl.rb 93% 87% -6%
dev-cmd/release.rb 23% 23% 0%
dev-cmd/formula-analytics.rb 17% 18% +1%
dev-cmd/generat...nalytics-api.rb 22% 23% +1%
bundle/subcommand.rb 94% 96% +2%
manpages.rb 50% 54% +4%
services/system.rb 81% 85% +4%
services/cli.rb 62% 69% +7%
extend/pathname.rb 75% 82% +7%
release_cooldown.rb 0% 100% +100%

Updated June 05, 2026 19:41 UTC
Code Coverage is in Public Preview. Learn more and provide us with your feedback.

@MikeMcQuaid MikeMcQuaid added this pull request to the merge queue Jun 5, 2026
Merged via the queue into main with commit 182fd8e Jun 5, 2026
38 checks passed
@MikeMcQuaid MikeMcQuaid deleted the ruby-bundler-cooldown branch June 5, 2026 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants