sorbet: Bump more tests to typed: true

[issyl0]

---

• Have you followed the guidelines in our Contributing document?
• Have you checked to ensure there aren't other open Pull Requests for the same change?
• Have you added an explanation of what your changes do and why you'd like us to include them? Performance claims (e.g. "this is faster") must include Hyperfine benchmarks.
• Have you written new tests (excluding integration tests) for your changes? Here's an example.
• Have you successfully run brew lgtm (style, typechecking and tests) with your changes locally?

---

• AI was used to generate or assist with generating this PR.

---

• This will be staying in a draft state until sorbet: Less RBI duplication to successfully typecheck RSpec tests #22540 is merged.
• Most of this was already in sorbet: Bump more tests to typed: true #22532, but that PR got closed (for good reason), so re-opening on top of the better branch.

[github-code-quality]

Code Coverage Overview

Languages: Ruby

Ruby / code-coverage/simplecov

The overall coverage in the sorbet-yet-more-test... branch is 75%. The coverage in the main branch is 78%.

Show a code coverage summary of the most impacted files.

File	main c6a08de	sorbet-yet-more-test... a27e37e	+/-
cask/info.rb	96%	0%	-96%
cask/installer.rb	91%	28%	-63%
cask/artifact/a...ct_uninstall.rb	89%	32%	-57%
cask/audit.rb	63%	25%	-38%
cask/cask_loader.rb	96%	65%	-31%
bundle/extensions/flatpak.rb	37%	94%	+57%
extend/os/linux/diagnostic.rb	0%	67%	+67%
os/linux/elf.rb	0%	86%	+86%
extend/os/linux/sandbox.rb	0%	95%	+95%
extend/os/linux...ystem_config.rb	0%	99%	+99%

---

_{Updated June 05, 2026 21:01 UTC
Code Coverage is in Public Preview. Learn more and provide us with your feedback.}

[Copilot]

Pull request overview

This PR increases Sorbet coverage in the Homebrew test suite by bumping additional specs to # typed: true (and one to # typed: strict) and making the minimal adjustments needed for those files to typecheck.

Changes:

• Bump multiple RSpec files from typed: false to typed: true / typed: strict.
• Add Sorbet-friendly “dummy” let values and T.bind annotations for DSL blocks used in specs.
• Make small Ruby adjustments to satisfy typing (e.g., avoiding return raise, coercing paths to strings).

Show a summary per file

File	Description
Library/Homebrew/test/utils/user_spec.rb	Replace multi-line Sorbet note with a concise dummy let comment.
Library/Homebrew/test/utils/string_inreplace_extension_spec.rb	Add/clarify dummy let(:string) needed for Sorbet.
Library/Homebrew/test/utils/ruby_check_version_script_spec.rb	Add/clarify dummy let(:required_ruby_version) needed for Sorbet.
Library/Homebrew/test/system_command_result_spec.rb	Bump to typed: true and add dummy stdout to satisfy typing.
Library/Homebrew/test/services/formula_wrapper_spec.rb	Bump to typed: true and adjust spec code for Sorbet (service file path handling).
Library/Homebrew/test/dev-cmd/lgtm_spec.rb	Bump to typed: true and adjust __dir__ usage for Sorbet.
Library/Homebrew/test/cmd/version-install_spec.rb	Bump to typed: true and simplify exception raising.
Library/Homebrew/test/cmd/update_spec.rb	Bump to typed: true and adjust __dir__ usage for Sorbet.
Library/Homebrew/test/cmd/log_spec.rb	Bump to typed: strict and ensure system receives string paths.
Library/Homebrew/test/cmd/bundle/remove_subcommand_spec.rb	Bump to typed: true, add Sorbet-focused dummy lets, and bind DSL self type in formula stub.
Library/Homebrew/test/cmd/bundle/list_subcommand_spec.rb	Bump to typed: true and refactor option-combination coverage to be Sorbet-friendly.
Library/Homebrew/test/cleaner_spec.rb	Bump to typed: true and add T.bind for formula DSL blocks.
Library/Homebrew/test/cask/dsl/container_spec.rb	Bump to typed: true and add dummy params for Sorbet.
Library/Homebrew/test/cask/dsl_spec.rb	Add/clarify dummy languages for Sorbet.
Library/Homebrew/test/cask/depends_on_spec.rb	Bump to typed: true and add a Sorbet-required top-level cask let.
Library/Homebrew/test/cask/artifact/zshcompletion_spec.rb	Bump to typed: true and add dummy cask_token for Sorbet.
Library/Homebrew/test/cask/artifact/manpage_spec.rb	Bump to typed: true and add dummy cask_token for Sorbet.
Library/Homebrew/test/cask/artifact/fishlcompletion_spec.rb	Bump to typed: true and add dummy cask_token for Sorbet.
Library/Homebrew/test/cask/artifact/bashcompletion_spec.rb	Bump to typed: true and add dummy cask_token for Sorbet.
Library/Homebrew/test/bundle/bundle_spec.rb	Bump to typed: true and add dummy brewfile_content for Sorbet.
Library/Homebrew/test/build_environment_spec.rb	Bump to typed: true and add a T.bind for DSL use in an anonymous class.

Copilot's findings

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comments suppressed due to low confidence (1)

Library/Homebrew/test/cask/depends_on_spec.rb:16

• There are now two identical let(:cask) definitions (outer one added for Sorbet, and another inside describe "depends_on cask"). The inner one is redundant and can be removed to reduce duplication and avoid confusion about which cask is in scope.

  let(:cask) { Cask::CaskLoader.load(cask_path("with-depends-on-cask")) } # Dummy value required for Sorbet.

  describe "depends_on cask" do
    let(:dependency) { Cask::CaskLoader.load(cask.depends_on.cask.first) }
    let(:cask) { Cask::CaskLoader.load(cask_path("with-depends-on-cask")) }

• Files reviewed: 21/21 changed files
• Comments generated: 1

[MikeMcQuaid]

Thanks! Same pattern in a few places (and perhaps in previous PRs too)

[MikeMcQuaid]

Looks good thanks!