Repository navigation
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
CodeQL found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
| namespace srt | ||
| { | ||
|
|
||
| // export import .api default; |
Check notice
Code scanning / CodeQL
Commented-out code Note
| typedef sync::steady_clock::time_point time_point; | ||
| typedef sync::steady_clock::duration duration; | ||
| CShaper (double min_tokens_capacity): | ||
| m_BurstPeriod(sync::milliseconds_from(BURSTPERIOD_DEFAULT())), |
Check warning
Code scanning / CodeQL
Lossy function result cast Warning
…r. Put CSndLossList to CSndBuffer. Explicit save/restore for SndRateMeasurement
…g destructor for CSndBuffer internal container
…ethods in one place. Added unit tests for sender loss handling.
| uint64_t basesize = m_uNumberBytes * 1000 * 1000; | ||
| uint64_t basetime = count_microseconds(diff); | ||
| if (basetime) // prevent division by 0 | ||
| m_uBytesPerSecond = (forespan * m_uBytesPerSecond + (basesize / basetime))/(forespan + 1); |
Check failure
Code scanning / CodeQL
Multiplication result converted to larger type High
| return READ_NONE; | ||
| } | ||
|
|
||
| // XXX unused? time_point entertime = steady_clock::now(); |
Check notice
Code scanning / CodeQL
Commented-out code Note
…ect and scheduled unique packing
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
…-hv-scheduled-sender-key-integration
Keep regular packets pending until crypto readiness and flight capacity allow timing. Let checkSndTimers drive forced refresh and retries, and wake scheduled sending on a valid crypto gate transition after releasing the connection lock. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
…v-scheduled-sender-key-integration
…w fixed printing help on stderr
…scheduled-sender-fixes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The new scheduled sending mode should work the following way:
To use this mode, add the
SRTO_SENDMODEoption with value 1.sendmodecan be used in the applications in the URI.Development phases:
m_tdSendIntervalas the sending interval base and then just forfeit time exceeding 1 second. Them_tdSendIntervalin case of live mode is using the "virtually unlimited" value or MAXBW can control the limit, as well as INPUTBW/OHEADBW. The "forfeit" mechanism means simply that you may potentially send packets that fast, but you don't because the packets scheduled for sending at the input (thesrt_sendmsg2calls) are sent slower than that. This means simply that packets are sent immediately, like before.