Skip DockerHub login on Dependabot PRs - #448
Open
mattjala wants to merge 1 commit into
Open
Conversation
Fixes HDFGroup#315. The `Docker Image CI` workflow fails on every Dependabot PR with an auth error at the login to DockerHub step. `docker/login-action` is given `secrets.DOCKERHUB_USERNAME` / `DOCKERHUB_PASSWORD`. When those resolve to empty strings it attempts the job anyway (and fails). Two kinds of run cannot see those secrets: * PRs from forks. GitHub withholds secrets from untrusted contributors. This case is already prevented from trying to login by the existing `! github.event.pull_request.head.repo.fork` check. * Dependabot PRs. GitHub resolves `secrets.*` for Dependabot-triggered runs against a separate Dependabot secret store, not the Actions store. Because Dependabot branches live in this repo, the existing check lets Dependabot PRs try to login to DockerHub. This isn't a problem for regular contributors because they either have write access and push a branch here (have secret access & login succeeds) or open a PR from a fork (no secret access & no login attempt). This PR extends the existing condition to also skip Dependabot.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
Docker Image CIworkflow fails on every Dependabot PR with an auth error at the login to DockerHub step.docker/login-actionis givensecrets.DOCKERHUB_USERNAME/DOCKERHUB_PASSWORD. When those resolve to empty strings it attempts the job anyway (and fails).Two kinds of run cannot see those secrets:
! github.event.pull_request.head.repo.forkcheck.secrets.*for Dependabot-triggered runs against a separate Dependabot secret store, not the Actions store.Because Dependabot branches live in this repo, the existing check lets Dependabot PRs try to login to DockerHub.
This isn't a problem for regular contributors because they either have write access and push a branch here (have secret access & login succeeds) or open a PR from a fork (no secret access & no login attempt).
This PR extends the existing condition to also skip Dependabot.
Fixes #315