Minor correction to H5Tget_super failure checks in JNI helpers - #6599
Open
mattjala wants to merge 1 commit into
Open
Minor correction to H5Tget_super failure checks in JNI helpers#6599mattjala wants to merge 1 commit into
mattjala wants to merge 1 commit into
Conversation
The base type lookups in the object-tree helpers tested the returned hid_t for truth rather than for a negative value. A failed lookup returns H5I_INVALID_HID (-1), resolving true when checked, so any failure wouldn't be caught until later.
Contributor
Review ChecklistThis PR touches the following areas. Each needs a sign-off
|
There was a problem hiding this comment.
Pull request overview
Fixes incorrect error handling in the Java JNI datatype translation helpers by ensuring failures from H5Tget_super() are detected immediately (using the standard negative-hid_t check), preventing invalid IDs from propagating and failing later.
Changes:
- Replace
!(hid_t)-style truthiness checks onH5Tget_super()results with explicit< 0failure checks in multiple translation/validation paths. - Align
H5Tget_super()error handling with existinghid_t-returning API conventions used elsewhere in the JNI code.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The base type lookups in the object-tree helpers tested the returned hid_t for truth rather than for a negative value. A failed lookup returns H5I_INVALID_HID, so any failure wouldn't be caught until later.
Rework the checks to use the more standard
< 0comparison for ID-related failures.