CMake remove noop policies - #6586
Open
scivision wants to merge 2 commits into
Open
Conversation
scivision
requested review from
jhendersonHDF,
lrknox and
mattjala
as code owners
July 31, 2026 17:00
Contributor
Review ChecklistThis PR touches the following areas. Each needs a sign-off
|
There was a problem hiding this comment.
Pull request overview
This PR removes explicit CMake policy settings that are expected to be redundant when configuring HDF5 with cmake_minimum_required(VERSION 3.26), with the stated goal of producing no behavior changes while simplifying the build configuration.
Changes:
- Removed explicit
cmake_policy(SET ...)blocks for several older policies in the top-levelCMakeLists.txt. - Removed the
CMAKE_POLICY_DEFAULT_CMP0077default in the plugin FetchContent integration.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| CMakePlugins.cmake | Simplifies FetchContent-based plugin configuration by removing a CMP0077 default (potentially behavior-affecting for subprojects). |
| CMakeLists.txt | Removes policy-setting blocks considered redundant under CMake 3.26+ and clarifies CMP0144 comment for CMake 3.27+. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
These are made no-ops by the cmake_minimum_required(VERSION 3.26) * CMP0074 by CMake 3.12 * CMP0077 by CMake 3.13 * CMP0083 by CMake 3.14 * CMP0127 by CMake 3.22 * CMP0135 by CMake 3.24
mattjala
approved these changes
Aug 4, 2026
lrknox
approved these changes
Aug 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These are made no-ops by the
cmake_minimum_required(VERSION 3.26)No behavior changes.