Code and test cleanup - #890
Draft
bmribler wants to merge 7 commits into
Draft
Conversation
There are missing VSdetach/Vend calls for VSattach/Vstart calls in both source and test code, causing memory leaks or unreachable blocks. The missing calls are added appropriately, resulting in a clean valgrind output in the testsuite. In addition, valgrind flagged "Conditional jump or move depends on uninitialised value(s)" in an mgr test (test_mgr_old_e), which is a known false positive caused by Valgrind's limited support for libjpeg-turbo's SIMD code, not an actual bug. A note is added to the test describing this.
bmribler
requested review from
brtnfld,
byrnHDF,
derobins,
fortnern,
glennsong09,
jhendersonHDF,
lrknox,
mattjala,
schwehr and
vchoi-hdfgroup
as code owners
August 7, 2026 04:42
bmribler
marked this pull request as draft
August 7, 2026 06:12
The 24-bit JPEG image comparison in the mgr test used exact memcmp, which is too strict across different libjpeg library versions/ platforms -- decoded pixel values can differ slightly due to rounding in IDCT/color conversion. Switched to fuzzy_memcmp with the existing JPEG_FUZZ tolerance.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Cleanup pass on VSattach/Vstart resource handling plus a valgrind false-positive note.
Changes
VSdetach/Vendcalls for correspondingVSattach/Vstartcalls in source and test code, fixing memory leaks/unreachable blocks flagged by valgrind.test_mgr_old_e) documenting a known valgrind false positive ("Conditional jump or move depends on uninitialised value(s)") caused by Valgrind's limited support for libjpeg-turbo's SIMD code — confirmed benign by rerunning withJSIMD_FORCENONE=1.Testing
Valgrind output is now clean across the testsuite (aside from the documented, confirmed-benign SIMD false positive).