Repository navigation
fix: deploy.sh updates an existing scheduled scan (--update-headers) - #23
Merged
Merged
Conversation
`gcloud scheduler jobs update http` has no `--headers`; its name there is `--update-headers`. The script used the `create` spelling for both verbs, so the second run of a deployment with SCHEDULES — the documented upgrade, the same command again — stopped at step 7 with `unrecognized arguments`. Present since the schedules of v17; met on the rc.2 finalize, the first deployment of the reference installation that carried SCHEDULES. The services were already deployed when it stopped and the jobs kept their earlier definition, so nothing was half-done. The verb and the flag are now chosen together; a test holds them together and the command carries the variable. The fixed update command was run against the existing jobs: accepted, definition unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
`gcloud scheduler jobs update http` has no `--headers` — its name there is `--update-headers`. `tools/deploy.sh` used the `create` spelling for both verbs, so the second run of a deployment with `SCHEDULES` (the documented upgrade: the same command again) stopped at step 7:
```
ERROR: (gcloud.scheduler.jobs.update.http) unrecognized arguments: --headers=Content-Type=application/json (did you mean '--clear-headers'?)
```
Present since the schedules of v17; met on the rc.2 finalize of the reference deployment, the first run there that carried `SCHEDULES`. The services were already deployed when it stopped and the jobs kept their earlier definition, so nothing was half-done.
Fix
Suite: 1,348 passed + 1 skipped.