complete the migration from thiserror to gix-error

.github/workflows/codeql.yml

@@ -56,6 +56,13 @@ jobs:
           build-mode: none
         - language: rust
           build-mode: none
+          # Path exclusions work with `none`; inline unit tests remain in scope.
+          config: |
+            paths-ignore:
+              - '**/examples/**'
+              - '**/tests/**'
+              - '**/fuzz/**'
+              - '**/benches/**'
         # CodeQL supports the following values keywords for 'language': 'actions', 'c-cpp', 'csharp', 'go', 'java-kotlin', 'javascript-typescript', 'python', 'ruby', 'rust', 'swift'
         # Use `c-cpp` to analyze code written in C, C++ or both
         # Use 'java-kotlin' to analyze code written in Java, Kotlin or both
@@ -82,6 +89,7 @@ jobs:
       with:
         languages: ${{ matrix.language }}
         build-mode: ${{ matrix.build-mode }}
+        config: ${{ matrix.config }}
         # If you wish to specify custom queries, you can do so here or in a config file.
         # By default, queries listed here will override any specified in a config file.
         # Prefix the list here with "+" to use these queries and those in the config file.

.gitignore

@@ -21,3 +21,8 @@ $**/fuzz/Cargo.lock
 
 # Instead of adding more environment-specific ignores here, like for the IDE in use, prefer Git's user-global
 # `core.excludesFile` mechanism, see https://git-scm.com/docs/git-config#Documentation/git-config.txt-coreexcludesFile.
+
+# Share Zed tasks even when editor files are ignored globally; keep other Zed settings local.
+!/.zed/
+/.zed/*
+!/.zed/tasks.json

.zed/tasks.json

@@ -0,0 +1,233 @@
+// Feature-specific test configurations, with both hashes enabled where applicable.
+// gix-transport has no hash toggles, so enable them on its gix-hash dev-dependency.
+// gix-error tests enable anyhow through a dev-dependency; tree-error overrides auto-chain-error.
+[
+  {
+    "label": "test gix-error (default tree)",
+    "command": "cargo",
+    "args": [
+      "nextest",
+      "run",
+      "-p",
+      "gix-error",
+      "--no-fail-fast"
+    ],
+    "cwd": "$ZED_WORKTREE_ROOT",
+    "env": { "GIX_TEST_IGNORE_ARCHIVES": "1" }
+  },
+  {
+    "label": "test gix-error (auto-chain-error)",
+    "command": "cargo",
+    "args": [
+      "nextest",
+      "run",
+      "-p",
+      "gix-error",
+      "--features",
+      "auto-chain-error",
+      "--no-fail-fast"
+    ],
+    "cwd": "$ZED_WORKTREE_ROOT",
+    "env": { "GIX_TEST_IGNORE_ARCHIVES": "1" }
+  },
+  {
+    "label": "test gix-error (auto-chain-error, tree-error)",
+    "command": "cargo",
+    "args": [
+      "nextest",
+      "run",
+      "-p",
+      "gix-error",
+      "--features",
+      "auto-chain-error,tree-error",
+      "--no-fail-fast"
+    ],
+    "cwd": "$ZED_WORKTREE_ROOT",
+    "env": { "GIX_TEST_IGNORE_ARCHIVES": "1" }
+  },
+  {
+    "label": "test gix-protocol (blocking-client)",
+    "command": "cargo",
+    "args": [
+      "nextest",
+      "run",
+      "-p",
+      "gix-protocol",
+      "--features",
+      "blocking-client,sha1,sha256",
+      "--no-fail-fast"
+    ],
+    "cwd": "$ZED_WORKTREE_ROOT",
+    "env": { "GIX_TEST_IGNORE_ARCHIVES": "1" }
+  },
+  {
+    "label": "test gix-protocol (async-client)",
+    "command": "cargo",
+    "args": [
+      "nextest",
+      "run",
+      "-p",
+      "gix-protocol",
+      "--features",
+      "async-client,sha1,sha256",
+      "--no-fail-fast"
+    ],
+    "cwd": "$ZED_WORKTREE_ROOT",
+    "env": { "GIX_TEST_IGNORE_ARCHIVES": "1" }
+  },
+  {
+    "label": "test gix-transport (curl)",
+    "command": "cargo",
+    "args": [
+      "nextest",
+      "run",
+      "-p",
+      "gix-transport",
+      "--features",
+      "http-client-curl,gix-hash/sha1,gix-hash/sha256",
+      "--no-fail-fast"
+    ],
+    "cwd": "$ZED_WORKTREE_ROOT",
+    "env": { "GIX_TEST_IGNORE_ARCHIVES": "1" }
+  },
+  {
+    "label": "test gix-transport (curl, insecure HTTP credentials)",
+    "command": "cargo",
+    "args": [
+      "nextest",
+      "run",
+      "-p",
+      "gix-transport",
+      "--features",
+      "http-client-curl,http-client-insecure-credentials,gix-hash/sha1,gix-hash/sha256",
+      "--test",
+      "blocking-transport-http-only",
+      "--no-fail-fast"
+    ],
+    "cwd": "$ZED_WORKTREE_ROOT",
+    "env": { "GIX_TEST_IGNORE_ARCHIVES": "1" }
+  },
+  {
+    "label": "test gix-transport (reqwest)",
+    "command": "cargo",
+    "args": [
+      "nextest",
+      "run",
+      "-p",
+      "gix-transport",
+      "--features",
+      "http-client-reqwest,gix-hash/sha1,gix-hash/sha256",
+      "--no-fail-fast"
+    ],
+    "cwd": "$ZED_WORKTREE_ROOT",
+    "env": { "GIX_TEST_IGNORE_ARCHIVES": "1" }
+  },
+  {
+    "label": "test gix-transport (reqwest, insecure HTTP credentials)",
+    "command": "cargo",
+    "args": [
+      "nextest",
+      "run",
+      "-p",
+      "gix-transport",
+      "--no-default-features",
+      "--features",
+      "blocking-client,http-client-reqwest,http-client-insecure-credentials,gix-hash/sha1,gix-hash/sha256",
+      "--test",
+      "blocking-transport",
+      "--no-fail-fast"
+    ],
+    "cwd": "$ZED_WORKTREE_ROOT",
+    "env": { "GIX_TEST_IGNORE_ARCHIVES": "1" }
+  },
+  {
+    "label": "test gix-transport (async-client)",
+    "command": "cargo",
+    "args": [
+      "nextest",
+      "run",
+      "-p",
+      "gix-transport",
+      "--features",
+      "async-client,gix-hash/sha1,gix-hash/sha256",
+      "--no-fail-fast"
+    ],
+    "cwd": "$ZED_WORKTREE_ROOT",
+    "env": { "GIX_TEST_IGNORE_ARCHIVES": "1" }
+  },
+  {
+    "label": "test gix (basic, comfort, max-performance-safe)",
+    "command": "cargo",
+    "args": [
+      "nextest",
+      "run",
+      "-p",
+      "gix",
+      "--no-default-features",
+      "--features",
+      "basic,comfort,max-performance-safe,sha1,sha256",
+      "--no-fail-fast"
+    ],
+    "cwd": "$ZED_WORKTREE_ROOT",
+    "env": { "GIX_TEST_IGNORE_ARCHIVES": "1" }
+  },
+  {
+    "label": "test gix (basic, extras, comfort)",
+    "command": "cargo",
+    "args": [
+      "nextest",
+      "run",
+      "-p",
+      "gix",
+      "--no-default-features",
+      "--features",
+      "basic,extras,comfort,sha1,sha256",
+      "--no-fail-fast"
+    ],
+    "cwd": "$ZED_WORKTREE_ROOT",
+    "env": { "GIX_TEST_IGNORE_ARCHIVES": "1" }
+  },
+  {
+    "label": "test gix (async-network-client)",
+    "command": "cargo",
+    "args": [
+      "nextest",
+      "run",
+      "-p",
+      "gix",
+      "--features",
+      "async-network-client,sha1,sha256",
+      "--no-fail-fast"
+    ],
+    "cwd": "$ZED_WORKTREE_ROOT",
+    "env": { "GIX_TEST_IGNORE_ARCHIVES": "1" }
+  },
+  {
+    "label": "test gix (blocking-network-client)",
+    "command": "cargo",
+    "args": [
+      "nextest",
+      "run",
+      "-p",
+      "gix",
+      "--features",
+      "blocking-network-client,sha1,sha256",
+      "--no-fail-fast"
+    ],
+    "cwd": "$ZED_WORKTREE_ROOT",
+    "env": { "GIX_TEST_IGNORE_ARCHIVES": "1" }
+  },
+  {
+    "label": "test gix (async-std, flaky)",
+    "command": "cargo",
+    "args": [
+      "test",
+      "-p",
+      "gix",
+      "--features",
+      "async-network-client-async-std,sha1,sha256"
+    ],
+    "cwd": "$ZED_WORKTREE_ROOT",
+    "env": { "GIX_TEST_IGNORE_ARCHIVES": "1" }
+  }
+]

AGENTS.md

@@ -37,21 +37,31 @@ Plumbing crates are migrating from `thiserror` enums to `gix-error`. Check wheth
 uses `gix-error` (look at its `Cargo.toml`); if it does, follow the patterns below. If it still uses
 `thiserror`, keep using `thiserror` for consistency within that crate.
 
-- **Error type alias**: `pub type Error = gix_error::Exn<gix_error::Message>;`
+- **Error types**: use `gix_error::Exn`, `gix_error::Exn<gix_error::Message>`, or the appropriate
+  concrete error directly, importing types under their canonical names as needed. Do not introduce
+  crate-specific or operation-specific forwarding aliases or renamed error exports.
+- **Exception results**: use `ExnResult<T, E>` for results with `Exn<E>` errors.
+  It defaults to `T = ()` and `E = gix_error::exn::Untyped`: use `ExnResult<T>` for erased errors,
+  bare `ExnResult` for erased unit results, and `ExnMessageResult<T>` for message contexts.
+  `ExnMessageResult` also defaults to unit success. Preserve concrete error types when adapting signatures.
+  Always import `ExnResult` and `ExnMessageResult` directly from `gix_error` (or their `gix` re-exports)
+  and use their bare names in signatures.
+- **Porcelain errors**: use the central `gix::Error` re-export at public API boundaries. Keep the
+  underlying error type and any `Exn` parameter when adapting an existing signature.
 - **Static messages**: `gix_error::message("something failed")`
 - **Formatted messages**: `gix_error::message!("failed to read {path}")`
 - **Wrapping callee errors with context**: `.or_raise(|| message("context about what failed"))?`
 - **Standalone error (no callee)**: `Err(message("something went wrong").raise())`
 - **Wrapping an `impl Error` with context**: `err.and_raise(message("context"))`
-- **Closure/callback bounds**: use `Result<T, Exn>` (bare), not `Exn<Message>`;
+- **Closure/callback bounds**: use `ExnResult<T>` with the default erased error type;
   inside the function, convert with `.or_raise(|| message("..."))?`;
   inside the closure, convert typed to bare with `.or_erased()`
 - **`Exn<E>` does NOT implement `std::error::Error`** — this is by design.
   - To convert: use `.into_error()` to get `gix_error::Error` (which does implement `std::error::Error`)
   - Example: `std::io::Error::other(exn.into_error())`
 - **In tests** returning `gix_testtools::Result` (= `Result<(), Box<dyn Error>>`), `Exn` can't be used
   with `?` directly — use `.map_err(|e| e.into_error())?`
-- **Common imports**: `use gix_error::{message, ErrorExt, ResultExt};`
+- **Common imports**: `use gix_error::{message, ErrorExt, ExnMessageResult, ExnResult, ResultExt};`
 - See `gix-error/src/lib.rs` module docs for a full migration guide from `thiserror`
 
 ### Commit Messages