Fix CMake package discovery and streamline library setup.#196
Closed
Priyanka328 wants to merge 6 commits into
Closed
Fix CMake package discovery and streamline library setup.#196Priyanka328 wants to merge 6 commits into
Priyanka328 wants to merge 6 commits into
Conversation
Priyanka328
commented
Mar 5, 2024
Priyanka328
commented
- Resolved CMake package discovery issue for external projects.
- Refactored library setup for improved modularity and organization.
- Enhanced installation process with proper targets.
- Added support for C++17 features in the library.
- Created a CMake export for the library interface to facilitate external use.
- Resolved CMake package discovery issue for external projects. - Refactored library setup for improved modularity and organization. - Enhanced installation process with proper targets. - Added support for C++17 features in the library. - Created a CMake export for the library interface to facilitate external use.
waywardmonkeys
left a comment
waywardmonkeys
left a comment
There was a problem hiding this comment.
This has been on my list to do so that I could finish up my vcpkg port…
Dekker1
suggested changes
Mar 27, 2024
Member
|
Thanks for the help in reviewing @waywardmonkeys and @Dekker1. Running the CI and will be testing locally as well. |
Author
|
Hi everyone, any updates? |
Member
|
Thanks for the contribution, and sorry this stayed open for so long. I reviewed this against the current I’m closing this as superseded. Thank you for the patch; it was still useful context while checking the current state. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.