Vastly simplify the build process and process for switching between Rider versions - #100
Merged
Merged
Conversation
Testing against a new Rider (e.g. an EAP) used to mean editing several values in several files, in two version formats, some of which could only be found by failing a restore. Now it's one line: <SdkVersion> in Directory.Build.props (exact NuGet form). - Gradle derives ProductVersion from it (2026.3.0-eap02 -> 2026.3-EAP2-SNAPSHOT), read via providers.fileContents so the configuration cache notices edits; -PProductVersion still overrides. `./gradlew riderVersions -q` shows both. - WaveVersion is derived by regex rather than fixed substrings; the unused UpperWaveVersion is gone. - JetBrains.Lifetimes/RdFramework/Annotations are no longer referenced directly: the ReferenceSdkCoreLibraries target compiles against the versions the SDK's own graph resolved (the SDK pins them exactly; main floated them to 2026.1.3 against the SDK's 2026.1.2). The ReSharper .nupkg no longer declares them as (leaked) dependencies. - SdkVersion is pinned exactly (2026.1.5.2, what 2026.1.* resolved to); the frontend now builds against the same Rider patch as the backend instead of 2026.1.0. - Plugin/tool versions live only in gradle/libs.versions.toml; the stale duplicates in gradle.properties and settings.gradle.kts are removed (they disagreed with what the build actually used). - :protocol:rdgen works again: RdGenTask is opted out of the configuration cache (it reads Task.project at execution time). Regenerated output is unchanged. See docs/rider-version.md. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Garethp
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.