Skip to content

fix(web-ui): refine model pool configuration and model selection - #3467

Merged
GCWing merged 1 commit into
mainfrom
gcwing/model-pool-selector-polish
Oct 20, 2026
Merged

GCWing merged 1 commit into
mainfrom
gcwing/model-pool-selector-polish

Conversation

@GCWing

@GCWing GCWing commented Oct 20, 2026 •

Copy link
Copy Markdown
Owner

Summary

Refine model pool configuration and keep selected model capsules consistent across the chat selector and provider settings.

  • Empty battery mode shows one centered “Configure model pools” action, without a redundant back/title row or empty-state hint.
  • Use illustrated routing cards, a fixed-height editor, searchable multi-selection, and numbered member capsules with reorder, retry and remove actions.
  • Apply filled selected states to provider discovery and selected model capsules. Include English, Simplified Chinese and Traditional Chinese copy.

Type and Areas

UI/UX, bug fix — Web UI model settings and chat model selection.

Motivation / Impact

Make configuring and selecting model pools compact and consistent with provider model selection. Preserve member order, legacy member IDs, extension fields and existing device capability gates. No persisted or wire formats change. Collaborative blueprint changes are excluded.

Verification

Passed locally in an isolated worktree based on the latest main:

pnpm --dir src/web-ui run test:run src/app/scenes/settings/pages/ai/ModelPoolsSection.test.tsx src/app/scenes/settings/pages/ai/ModelDiscoveryPicker.test.tsx src/infrastructure/config/components/common/SettingsControlSizing.test.ts src/infrastructure/config/components/ModelSettingsDialog.presentation.test.ts src/app/scenes/settings/pages/ai/ModelSettingsPage.presentation.test.ts src/infrastructure/appearance/registry/AppearanceRegistry.test.ts src/flow_chat/components/ModelSelectorProviderLevels.test.tsx src/shared/ui/MenuComposition.contract.test.ts
pnpm --dir src/web-ui run gen:types
pnpm --dir src/web-ui exec tsc --noEmit
pnpm run i18n:audit
pnpm run appearance:contract-audit
pnpm run theme:color-audit:all
pnpm run theme:visual-contract
node scripts/check-git-object-sizes.mjs --base origin/main --head HEAD
git diff --check

80 focused UI tests and 39 protocol binding export tests passed. TypeScript type-check and ESLint passed for the changed production TypeScript files.

pnpm run check:web stops at two existing typography violations on main in src/mobile-web/src/styles/components/markdown.scss:506–507 (font-size: 1.05em, line-height: 1.2), outside this PR. Its remaining Appearance and theme gates were run separately and passed.

Reviewer Notes

AI-assisted implementation with focused automated testing. The routing illustration is AI-generated; no transient generation prompts are included. No browser/computer-control verification was performed, as requested. Device-switch and unsupported-peer DOM fixtures were exercised; live SSH workspace, relay remote control, Peer Device Mode and Detached Dispatch were not exercised.

Checklist

  • This PR is focused and does not include secrets, temporary prompts, generated scratch files, or unrelated artifacts.
  • Relevant verification is recorded above, or skipped checks are explained.
  • User-facing strings, docs, and locales are updated where applicable.

@GCWing
GCWing merged commit 9eebcbd into main Oct 20, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant