Repository navigation
fix(web-ui): refine model pool configuration and model selection - #3467
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refine model pool configuration and keep selected model capsules consistent across the chat selector and provider settings.
Type and Areas
UI/UX, bug fix — Web UI model settings and chat model selection.
Motivation / Impact
Make configuring and selecting model pools compact and consistent with provider model selection. Preserve member order, legacy member IDs, extension fields and existing device capability gates. No persisted or wire formats change. Collaborative blueprint changes are excluded.
Verification
Passed locally in an isolated worktree based on the latest main:
pnpm --dir src/web-ui run test:run src/app/scenes/settings/pages/ai/ModelPoolsSection.test.tsx src/app/scenes/settings/pages/ai/ModelDiscoveryPicker.test.tsx src/infrastructure/config/components/common/SettingsControlSizing.test.ts src/infrastructure/config/components/ModelSettingsDialog.presentation.test.ts src/app/scenes/settings/pages/ai/ModelSettingsPage.presentation.test.ts src/infrastructure/appearance/registry/AppearanceRegistry.test.ts src/flow_chat/components/ModelSelectorProviderLevels.test.tsx src/shared/ui/MenuComposition.contract.test.ts pnpm --dir src/web-ui run gen:types pnpm --dir src/web-ui exec tsc --noEmit pnpm run i18n:audit pnpm run appearance:contract-audit pnpm run theme:color-audit:all pnpm run theme:visual-contract node scripts/check-git-object-sizes.mjs --base origin/main --head HEAD git diff --check80 focused UI tests and 39 protocol binding export tests passed. TypeScript type-check and ESLint passed for the changed production TypeScript files.
pnpm run check:webstops at two existing typography violations on main insrc/mobile-web/src/styles/components/markdown.scss:506–507(font-size: 1.05em,line-height: 1.2), outside this PR. Its remaining Appearance and theme gates were run separately and passed.Reviewer Notes
AI-assisted implementation with focused automated testing. The routing illustration is AI-generated; no transient generation prompts are included. No browser/computer-control verification was performed, as requested. Device-switch and unsupported-peer DOM fixtures were exercised; live SSH workspace, relay remote control, Peer Device Mode and Detached Dispatch were not exercised.
Checklist