Repository navigation
fix(macos): bundle native icons with verified legacy fallback - #3348
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
macOS packaging now includes a native Icon Composer catalog for macOS 26/27 and a verified ICNS fallback for development and older macOS releases. The modern source stays full bleed; the legacy export has its own authored transparent canvas and ten native representations.
Type and Areas
Type: bug fix, packaging, CI, dependency, docs.
Areas: Desktop/Tauri, Installer, brand resources, release and nightly workflows.
Motivation / Impact
Verification
Passed locally:
pnpm run generate-brand-assetsnode --test scripts/generate-brand-assets.test.mjs scripts/macos-icon-bundle.test.mjs scripts/desktop-tauri-build.test.mjs— 46 passed, 1 skipped.pnpm run test:release-packaging— 79 passed, 1 skipped.pnpm run check:github-config— YAML validation and 29 tests passed; the PowerShell truth-table test was skipped because pwsh is unavailable locally.pnpm run check:repo-hygienenode scripts/check-git-object-sizes.mjs --base origin/main --head HEADgit diff --checkApple iconutil decoding and actual legacy Tauri fixture bundling passed without launching UI. Full modern fixture bundling and the full Desktop/Installer build were not run locally because this Mac has Command Line Tools without full Xcode; the modified release/nightly workflows require the modern fixture on both macOS architectures. Automated resource checks do not establish visual Dock equivalence.
Reviewer Notes
AI-assisted; locally tested at the resource and packaging-contract level. No browser or computer-use validation was performed.
Remote workspace, remote control, Peer Device Mode, and Detached Dispatch were not exercised. This change is limited to host packaging and does not alter runtime commands, persisted data, or remote protocols.
Checklist