Conversation
| ReadinessPort uint16 = 8338 | ||
| // MetricsPort exposes op-batcher's Prometheus endpoint (--metrics.port) out of | ||
| // the enclave so a host-side collector can scrape it. | ||
| MetricsPort uint16 = 7300 |
Collaborator
There was a problem hiding this comment.
So is the Prometheus service already configured to run or will this be done in another PR?
Member
Author
There was a problem hiding this comment.
This is so we can build an enclave image that has that port available when we run the batch poster! So the other PR that sets up Prometheus will happen in the op-deploy-combined repository.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
MetricsPort(7300) to the enclave ingress list so a host-side collector can scrapeop-batcher's--metrics endpoint(the port is otherwise unreachable, logs escape viastdoutrelay, but Prometheus is pull, needing ingress).