Skip to content

fix: limb range check for fpelem - #894

Open
mrain wants to merge 1 commit into
mainfrom
cl/fpelem-limb-range-check
Open

mrain wants to merge 1 commit into
mainfrom
cl/fpelem-limb-range-check

Conversation

@mrain

@mrain mrain commented Aug 3, 2026 •

Copy link
Copy Markdown
Contributor

closes: #XXXX

This PR:

Missing limb range check when creating FpElemVar leads to fiat shamir soundness break.
This PR fixes it, with regression tests.

This PR does not:

Key places to review:


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (main)
  • Linked to GitHub issue with discussion and accepted design OR have an explanation in the PR that describes this work.
  • Wrote unit tests
  • Updated relevant documentation in the code
  • Added relevant changelog entries to the CHANGELOG.md of touched crates.
  • Re-reviewed Files changed in the GitHub PR explorer

@gemini-code-assist

Copy link
Copy Markdown
Contributor

Caution

The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased.

@mrain
mrain requested a review from philippecamacho August 3, 2026 19:11

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant