fix(color): Ghost module config page cannot be exited with no module attached

[juricabi]

Fixes #7597.

This picks up where #7598 left off. The first commit is philmoz's change from that PR, which fixes the "can't exit" part of the issue. While testing it on my radio I found the page still locks up on the navigation keys, so the second commit deals with that, and the third adds the waiting message the issue mentions.

The remaining lockup

With #7598 applied long RTN gets you out, but pressing SYS, MDL or TELE still freezes the radio.

Those keys, short and long, all end up in NavWindow::doKeyShortcut(). Page::doKeyShortcut() calls onCancel() and then forwards the event to navWindow(), which works because normally onCancel() has popped the page off the layer stack and navWindow() resolves to whatever is underneath. This page overrides onCancel() to navigate the Ghost menu instead of closing, so Window::topWindow() still returns the Ghost page and doKeyShortcut() ends up calling itself until the stack runs out.

With the default shortcuts that is 5 of the 6 bindings. Short SYS is the exception, since it maps to QM_OPEN_QUICK_MENU and takes the other branch.

The fix is to ignore the shortcut while this page is open. That matches what the rest of the tools already do: radio_diagkeys.h, widgets_setup.h and topbar.h all override these keys with empty bodies, and Lua tool pages ignore them too because StandaloneLuaWindow derives from Window rather than NavWindow and so has no doKeyShortcut() at all. Long RTN still leaves the page.

This does mean a short SYS press no longer opens the quick menu from this page, where previously it did — it was the one binding that did not hang, since QM_OPEN_QUICK_MENU takes the other branch. That path did not really work anyway: Page calls onCancel() when a quick menu item is picked, and this page's onCancel() navigates the Ghost menu instead of closing, so choosing an entry left you still in the Ghost menu having sent a stray GHST_BTN_JOYLEFT to the module.

Waiting message

The body was blank until a module answered, so nothing on screen said what it was waiting for. This uses STR_WAITING_FOR_MODULE, the same as the B&W menu in gui/common/stdlcd/radio_ghost_menu.cpp.

About the timeout

The issue also asks for the page to close itself after a while. I left that out on purpose: the B&W menu has no timeout either, and it seems better to keep the two consistent than to add one only on colour. With these changes there is no longer a state you cannot get out of.

Testing

On a HelloRadioSky V12 (colour 320x240, keys and rotary encoder).

With a Ghost module connected the menu opens, navigates and closes normally, as before.

With no module attached:

• long RTN exits
• SYS / MDL / TELE no longer freeze the radio; they are ignored while the page is open, as on other tool pages
• short RTN still moves around inside the Ghost menu
• the waiting message shows instead of a blank body

I also unplugged the module while still in the menu. The screen stops updating and keeps showing the last state, but the keys keep working and the page can be left normally, so nothing locks up there either.

NV14 / PL18

Not affected. targets/pl18/CMakeLists.txt defines -DPCBPL18 for all of its revisions, NV14 included, and both onLongPressRTN() and the new doKeyShortcut() sit inside the #if defined(HARDWARE_KEYS) && !defined(PCBPL18) block. I built PCB=PL18 PCBREV=NV14 to check and neither symbol ends up in the binary, so those targets keep their current behaviour.