Skip to content

chore: cleanup strings - #7590

Open
philmoz wants to merge 2 commits into
mainfrom
philmoz/cleanup-strings
Open

chore: cleanup strings#7590
philmoz wants to merge 2 commits into
mainfrom
philmoz/cleanup-strings

Conversation

@philmoz

@philmoz philmoz commented Jul 27, 2026

Copy link
Copy Markdown
Collaborator

Changes:

  • Delete unused translation strings.
  • Use STR_xx names in code (not TR_xxx).
  • Move sensor names to telemetry folder (not translated).
  • Simplify handling of untranslated strings.
  • Update fonts.

@philmoz philmoz added this to the 3.0 milestone Jul 27, 2026
@philmoz philmoz added house keeping 🧹 Cleanup of code and house keeping firmware General radio firmware issue, not colorlcd or B&W specific labels Jul 27, 2026
@pfeerick
pfeerick requested a review from Copilot August 2, 2026 01:39

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR refactors the radio firmware’s string/translation handling by removing unused translation keys, standardizing on STR_* identifiers in code, and moving telemetry sensor “names” into a non-translated header, alongside an update to Hebrew LVGL font assets.

Changes:

  • Removed the separate “not translated” string list and cleaned up unused translation keys across multiple locales.
  • Updated telemetry and UI call-sites to use STR_* names consistently, and introduced sensor_names.h for non-translated telemetry sensor labels.
  • Updated LVGL Hebrew font data and mappings.

Reviewed changes

Copilot reviewed 60 out of 136 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
radio/src/translations/translations.h Removes string_list_notrans.h usage and consolidates string declarations.
radio/src/translations/translations.cpp Cleans up language include ordering and removes no-longer-used notrans string handling.
radio/src/translations/string_list.h Removes unused keys, reorders some entries, and adds CHR_INPUT as a string.
radio/src/translations/string_list_notrans.h Deletes the legacy “not translated” string list.
radio/src/translations/simstr.m4 Adds regeneration instructions for sim_string_list.h.
radio/src/translations/i18n/pt.h Removes unused translation definitions and updates TR_CHR_INPUT to a string literal.
radio/src/translations/i18n/nl.h Removes unused translation definitions and updates TR_CHR_INPUT to a string literal.
radio/src/translations/i18n/fi.h Removes unused translation definitions and updates TR_CHR_INPUT to a string literal.
radio/src/translations/i18n/es.h Removes unused translation definitions and updates TR_CHR_INPUT to a string literal.
radio/src/translations/i18n/en.h Removes unused translation definitions and updates TR_CHR_INPUT to a string literal.
radio/src/telemetry/telemetry.cpp Includes sensor_names.h to use non-translated RX stat labels/units.
radio/src/telemetry/sensor_names.h Adds centralized non-translated telemetry sensor name constants (new file).
radio/src/telemetry/mlink.cpp Switches MLink sensor naming from translation indirection to non-translated constants.
radio/src/telemetry/hott.cpp Switches HoTT sensor naming from translation indirection to non-translated constants.
radio/src/telemetry/hitec.cpp Switches Hitec sensor naming from translation indirection to non-translated constants.
radio/src/telemetry/ghost.cpp Switches Ghost sensor naming from translation indirection to non-translated constants.
radio/src/telemetry/frsky_sport.cpp Includes sensor_names.h for non-translated sensor labels.
radio/src/telemetry/frsky_d.cpp Switches FrSky D sensor naming from translation indirection to non-translated constants.
radio/src/telemetry/flysky_nv14.cpp Switches FlySky NV14 sensor naming from translation indirection to non-translated constants.
radio/src/telemetry/flysky_ibus.cpp Switches FlySky iBus sensor naming from translation indirection to non-translated constants.
radio/src/telemetry/crossfire.cpp Switches Crossfire sensor naming from translation indirection to non-translated constants.
radio/src/hal/rgbleds.h Updates comment to reference STR_* naming.
radio/src/gui/common/stdlcd/draw_functions.cpp Uses STR_CHR_INPUT string instead of a single CHR_INPUT char.
radio/src/gui/colorlcd/widgets/value.cpp Introduces a local STR_V alias for the voltage unit string.
radio/src/gui/212x64/view_statistics.cpp Switches from TR_TIME to STR_TIME.
radio/src/gui/212x64/model_setup.cpp Replaces remaining TR_* usage with STR_* in warning info length calculation and AFHDS3 label.
radio/src/gui/128x64/model_setup.cpp Replaces TR_* usage with STR_* for telemetry-type label and AFHDS3 label.
radio/src/fonts/lvgl/std/lv_font_he_XXS.c Updates compressed Hebrew XXS font payload and cmap metadata.
radio/src/fonts/lvgl/std/lv_font_he_STD.c Updates Hebrew STD font glyph set (drops niqqud marks) and adjusts cmap/metrics.
radio/src/fonts/lvgl/sml/lv_font_he_XXS.c Updates compressed Hebrew XXS (small) font payload and cmap metadata.
radio/src/fonts/lvgl/sml/lv_font_he_STD.c Updates Hebrew STD (small) font glyph set and adjusts cmap/metrics.
radio/src/fonts/lvgl/sml/lv_font_he_L.c Updates compressed Hebrew L (small) font payload and cmap metadata.
radio/src/fonts/lvgl/lrg/lv_font_he_STD.c Updates Hebrew STD (large) font glyph set/cmap to match new range selection.
radio/src/edgetx.h Updates comment to reference STR_CURRENT_VERSION.
radio/src/edgetx.cpp Fixes a remaining TR_TEST_NOTSAFE usage to STR_TEST_NOTSAFE.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread radio/src/telemetry/sensor_names.h
Comment thread radio/src/telemetry/sensor_names.h Outdated
@philmoz
philmoz force-pushed the philmoz/cleanup-strings branch from e19d6fc to a392a3f Compare August 2, 2026 01:54
philmoz added 2 commits August 5, 2026 14:14
Use STR_xx names.
Move sensor names to telemetry folder.
Update fonts.
@philmoz
philmoz force-pushed the philmoz/cleanup-strings branch from a392a3f to 9ba2a68 Compare August 5, 2026 04:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

firmware General radio firmware issue, not colorlcd or B&W specific house keeping 🧹 Cleanup of code and house keeping

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants