chore: cleanup strings - #7590
Open
philmoz wants to merge 2 commits into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR refactors the radio firmware’s string/translation handling by removing unused translation keys, standardizing on STR_* identifiers in code, and moving telemetry sensor “names” into a non-translated header, alongside an update to Hebrew LVGL font assets.
Changes:
- Removed the separate “not translated” string list and cleaned up unused translation keys across multiple locales.
- Updated telemetry and UI call-sites to use
STR_*names consistently, and introducedsensor_names.hfor non-translated telemetry sensor labels. - Updated LVGL Hebrew font data and mappings.
Reviewed changes
Copilot reviewed 60 out of 136 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| radio/src/translations/translations.h | Removes string_list_notrans.h usage and consolidates string declarations. |
| radio/src/translations/translations.cpp | Cleans up language include ordering and removes no-longer-used notrans string handling. |
| radio/src/translations/string_list.h | Removes unused keys, reorders some entries, and adds CHR_INPUT as a string. |
| radio/src/translations/string_list_notrans.h | Deletes the legacy “not translated” string list. |
| radio/src/translations/simstr.m4 | Adds regeneration instructions for sim_string_list.h. |
| radio/src/translations/i18n/pt.h | Removes unused translation definitions and updates TR_CHR_INPUT to a string literal. |
| radio/src/translations/i18n/nl.h | Removes unused translation definitions and updates TR_CHR_INPUT to a string literal. |
| radio/src/translations/i18n/fi.h | Removes unused translation definitions and updates TR_CHR_INPUT to a string literal. |
| radio/src/translations/i18n/es.h | Removes unused translation definitions and updates TR_CHR_INPUT to a string literal. |
| radio/src/translations/i18n/en.h | Removes unused translation definitions and updates TR_CHR_INPUT to a string literal. |
| radio/src/telemetry/telemetry.cpp | Includes sensor_names.h to use non-translated RX stat labels/units. |
| radio/src/telemetry/sensor_names.h | Adds centralized non-translated telemetry sensor name constants (new file). |
| radio/src/telemetry/mlink.cpp | Switches MLink sensor naming from translation indirection to non-translated constants. |
| radio/src/telemetry/hott.cpp | Switches HoTT sensor naming from translation indirection to non-translated constants. |
| radio/src/telemetry/hitec.cpp | Switches Hitec sensor naming from translation indirection to non-translated constants. |
| radio/src/telemetry/ghost.cpp | Switches Ghost sensor naming from translation indirection to non-translated constants. |
| radio/src/telemetry/frsky_sport.cpp | Includes sensor_names.h for non-translated sensor labels. |
| radio/src/telemetry/frsky_d.cpp | Switches FrSky D sensor naming from translation indirection to non-translated constants. |
| radio/src/telemetry/flysky_nv14.cpp | Switches FlySky NV14 sensor naming from translation indirection to non-translated constants. |
| radio/src/telemetry/flysky_ibus.cpp | Switches FlySky iBus sensor naming from translation indirection to non-translated constants. |
| radio/src/telemetry/crossfire.cpp | Switches Crossfire sensor naming from translation indirection to non-translated constants. |
| radio/src/hal/rgbleds.h | Updates comment to reference STR_* naming. |
| radio/src/gui/common/stdlcd/draw_functions.cpp | Uses STR_CHR_INPUT string instead of a single CHR_INPUT char. |
| radio/src/gui/colorlcd/widgets/value.cpp | Introduces a local STR_V alias for the voltage unit string. |
| radio/src/gui/212x64/view_statistics.cpp | Switches from TR_TIME to STR_TIME. |
| radio/src/gui/212x64/model_setup.cpp | Replaces remaining TR_* usage with STR_* in warning info length calculation and AFHDS3 label. |
| radio/src/gui/128x64/model_setup.cpp | Replaces TR_* usage with STR_* for telemetry-type label and AFHDS3 label. |
| radio/src/fonts/lvgl/std/lv_font_he_XXS.c | Updates compressed Hebrew XXS font payload and cmap metadata. |
| radio/src/fonts/lvgl/std/lv_font_he_STD.c | Updates Hebrew STD font glyph set (drops niqqud marks) and adjusts cmap/metrics. |
| radio/src/fonts/lvgl/sml/lv_font_he_XXS.c | Updates compressed Hebrew XXS (small) font payload and cmap metadata. |
| radio/src/fonts/lvgl/sml/lv_font_he_STD.c | Updates Hebrew STD (small) font glyph set and adjusts cmap/metrics. |
| radio/src/fonts/lvgl/sml/lv_font_he_L.c | Updates compressed Hebrew L (small) font payload and cmap metadata. |
| radio/src/fonts/lvgl/lrg/lv_font_he_STD.c | Updates Hebrew STD (large) font glyph set/cmap to match new range selection. |
| radio/src/edgetx.h | Updates comment to reference STR_CURRENT_VERSION. |
| radio/src/edgetx.cpp | Fixes a remaining TR_TEST_NOTSAFE usage to STR_TEST_NOTSAFE. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
philmoz
force-pushed
the
philmoz/cleanup-strings
branch
from
August 2, 2026 01:54
e19d6fc to
a392a3f
Compare
added 2 commits
August 5, 2026 14:14
Use STR_xx names. Move sensor names to telemetry folder. Update fonts.
philmoz
force-pushed
the
philmoz/cleanup-strings
branch
from
August 5, 2026 04:14
a392a3f to
9ba2a68
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes: