chore(spiflash): improve the efficiency of "is block erased" detection - #7582
Open
richardclli wants to merge 1 commit into
Open
chore(spiflash): improve the efficiency of "is block erased" detection#7582richardclli wants to merge 1 commit into
richardclli wants to merge 1 commit into
Conversation
📝 WalkthroughWalkthrough
ChangesFlash and FTL updates
Estimated code review effort: 2 (Simple) | ~10 minutes 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
richardclli
force-pushed
the
richardclli/fix-spiflash-efficiency
branch
from
July 24, 2026 06:32
3cf27f5 to
f18c6f1
Compare
richardclli
marked this pull request as draft
July 27, 2026 04:33
richardclli
marked this pull request as ready for review
July 27, 2026 05:00
Member
Author
|
Tested, this change is already in my daily use radio. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The spi_flash.cpp flashSpiIsErased function is not efficient, it only use byte by byte read and it is slow.
New strategy:
This can guarantee the efficiency of is erase detection for both used and erased blocks.
2.11 fix combines in #7472, no need to merge to 2.11 branch
Summary by CodeRabbit