fix(log): present export errors instead of dropping them - #34
Open
Nyvernn wants to merge 1 commit into
Open
Conversation
Collaborator
|
这个是实际遇到并且影响体验的问题吗 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LogViewhas two.alert(item:)modifiers on the same view. SwiftUI does not reliablypresent both, and it is the second that loses, so every export error -- including
"Log file not found." -- was discarded without a trace and the share button looked like
it did nothing.
One alert, fed by whichever of the two sources has a message.