Eng 1801: query builder column resize lag by sid597 · Pull Request #1125 · DiscourseGraphs/discourse-graph

sid597 · 2026-06-15T09:23:02Z

Summary by CodeRabbit

Bug Fixes

Improved table column resizing behavior with enhanced responsiveness and reliability
Column width preferences are now automatically saved and restored

linear-code · 2026-06-15T09:23:05Z

ENG-1801

vercel · 2026-06-15T09:23:08Z

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment

Project	Deployment	Actions	Updated (UTC)
discourse-graph	Skipped		Jun 16, 2026 11:29am

supabase · 2026-06-15T09:23:10Z

This pull request has been ignored for the connected project zytfjzqyijgagqxrzbmz because there are no changes detected in packages/database/supabase directory. You can change this behaviour in Project Integrations Settings ↗︎.

Preview Branches by Supabase.
Learn more about Supabase Branching ↗︎.

sid597 · 2026-06-15T09:25:15Z

@coderabbitai full review

coderabbitai · 2026-06-15T09:25:22Z

✅ Action performed

Full review finished.

devin-ai-integration

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

coderabbitai · 2026-06-15T09:30:10Z

📝 Walkthrough

Walkthrough

Replaces HTML drag-and-drop column resizing in ResultsTable.tsx with Pointer Events handlers (onPointerDown/Move/Up/Cancel/LostPointerCapture). Introduces a new DragInfo state model tracking pointer id and header start widths, and adds a body.roamjs-query-column-resizing CSS class to enforce the resize cursor and suppress text selection.

Changes

Pointer Events Column Resizing

Layer / File(s)	Summary
DragInfo model, constants, and resize CSS `apps/roam/src/components/results-view/ResultsTable.tsx`, `apps/roam/src/styles/styles.css`	Adds `COLUMN_RESIZING_CLASSNAME` and `MIN_COLUMN_WIDTH` constants; replaces the legacy drag metadata shape with a pointer-centric `DragInfo` model (pointerId, movement state, left/right header elements, starting widths) and a `getInitialDragInfo` initializer; adds the `body.roamjs-query-column-resizing` CSS rule that sets `ew-resize` cursor and `user-select: none`.
Pointer resize lifecycle handlers `apps/roam/src/components/results-view/ResultsTable.tsx`	Implements `onResizeStart` (sets pointer capture, adds body CSS class), `onResize` (adjusts header widths from pointer delta), `finishResize` (releases capture, removes CSS class, computes final width percentages with minimum-percent constraint, persists to Roam layout via `setInputSettings`), `onResizeEnd`, `onResizeLostPointerCapture`, and an unmount cleanup `useEffect` that removes the body CSS class.
Component props and JSX handle wiring `apps/roam/src/components/results-view/ResultsTable.tsx`	Updates `ResultRowProps` to declare four pointer-resize handler props; adjusts `ResultRow` destructuring; replaces the resize handle element's `draggable`/drag-event attributes with pointer event handlers and `touchAction: "none"`; updates the `ResultRow` call site to pass the new handlers.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

DiscourseGraphs/discourse-graph#270: Modifies the same ResultsTable.tsx column-resizing logic and handler lifecycle, establishing the drag-based resizing that this PR replaces with Pointer Events.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title directly addresses the main change: fixing column resize lag in the query builder, which aligns with the PR's focus on reworking table column resizing from HTML drag-and-drop to Pointer Events-based approach.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

coderabbitai

🧹 Nitpick comments (1)

apps/roam/src/styles/styles.css (1)
39-43: 💤 Low value

Consider adding !important to user-select for consistency.

The cursor property uses !important to ensure it overrides element-specific styles, but user-select: none doesn't. If any child element has an explicit user-select value, text selection during resize could still occur.
Suggested change
 body.roamjs-query-column-resizing,
 body.roamjs-query-column-resizing * {
   cursor: ew-resize !important;
-  user-select: none;
+  user-select: none !important;
 }
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@apps/roam/src/styles/styles.css` around lines 39 - 43, The user-select
property in the body.roamjs-query-column-resizing and
body.roamjs-query-column-resizing * selector lacks the !important flag while
cursor: ew-resize has it. Add !important to the user-select: none declaration
for consistency, ensuring child elements cannot override the selection
restriction during column resizing operations.

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In `@apps/roam/src/styles/styles.css`:
- Around line 39-43: The user-select property in the
body.roamjs-query-column-resizing and body.roamjs-query-column-resizing *
selector lacks the !important flag while cursor: ew-resize has it. Add
!important to the user-select: none declaration for consistency, ensuring child
elements cannot override the selection restriction during column resizing
operations.

ℹ️ Review info

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 104be335-338c-4399-80fd-089acf18f8c9

📥 Commits

Reviewing files that changed from the base of the PR and between 7195930 and 6ce9a03.

📒 Files selected for processing (2)

apps/roam/src/components/results-view/ResultsTable.tsx
apps/roam/src/styles/styles.css

sid597 · 2026-06-16T08:39:26Z

@codex review

chatgpt-codex-connector · 2026-06-16T08:48:10Z

Codex Review: Didn't find any major issues. 👍

Reviewed commit: 6ce9a03c5b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

sid597 added 2 commits June 10, 2026 14:23

ENG-1801 Fix query builder column resize lag

5d53944

ENG-1801 Harden query column resize cleanup

6ce9a03

devin-ai-integration Bot reviewed Jun 15, 2026

View reviewed changes

coderabbitai Bot reviewed Jun 15, 2026

View reviewed changes

ENG-1801 Restore query column widths after resize

c15902d

vercel Bot temporarily deployed to Preview June 16, 2026 11:29 Inactive

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Eng 1801: query builder column resize lag#1125

Eng 1801: query builder column resize lag#1125
sid597 wants to merge 3 commits into
mainfrom
eng-1801-query-builder-column-resize-lag

sid597 commented Jun 15, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

linear-code Bot commented Jun 15, 2026

Uh oh!

vercel Bot commented Jun 15, 2026 •

edited

Loading

Uh oh!

supabase Bot commented Jun 15, 2026

Uh oh!

sid597 commented Jun 15, 2026

Uh oh!

coderabbitai Bot commented Jun 15, 2026 •

edited

Loading

Uh oh!

devin-ai-integration Bot left a comment

Uh oh!

coderabbitai Bot commented Jun 15, 2026

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Uh oh!

coderabbitai Bot left a comment

Uh oh!

sid597 commented Jun 16, 2026

Uh oh!

chatgpt-codex-connector Bot commented Jun 16, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

sid597 commented Jun 15, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Bug Fixes

Uh oh!

linear-code Bot commented Jun 15, 2026

Uh oh!

vercel Bot commented Jun 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

supabase Bot commented Jun 15, 2026

Uh oh!

sid597 commented Jun 15, 2026

Uh oh!

coderabbitai Bot commented Jun 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

devin-ai-integration Bot left a comment

Choose a reason for hiding this comment

✅ Devin Review: No Issues Found

Uh oh!

coderabbitai Bot commented Jun 15, 2026

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

sid597 commented Jun 16, 2026

Uh oh!

chatgpt-codex-connector Bot commented Jun 16, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

sid597 commented Jun 15, 2026 •

edited by coderabbitai Bot

Loading

vercel Bot commented Jun 15, 2026 •

edited

Loading

coderabbitai Bot commented Jun 15, 2026 •

edited

Loading