ENG-1685: Set default state for import modal to have all list items unselected#1120
ENG-1685: Set default state for import modal to have all list items unselected#1120sid597 wants to merge 1 commit into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
There was a problem hiding this comment.
🚩 Inconsistent excludeImported filtering between DataCore and fallback paths
Pre-existing issue: In getFilesWithNodeTypeId, the DataCore path at apps/obsidian/src/services/QueryEngine.ts:377 checks for both fm?.importedFromRid || fm?.importedFromSpaceUri, but the fallback fallbackGetFilesWithNodeTypeId at apps/obsidian/src/services/QueryEngine.ts:537 only checks for importedFromRid. This means files imported via importedFromSpaceUri would be excluded when DataCore is available but included in the fallback path. Not introduced by this PR but worth noting as it's in the same file.
(Refers to lines 535-540)
Was this helpful? React with 👍 or 👎 to provide feedback.
There was a problem hiding this comment.
@trangdoan982 this is a pre-existing issue not sure if we want to address it here or create a new pr, I am fine with both options
There was a problem hiding this comment.
oh i don't mind having it included in this PR. small change. thanks Sid
trangdoan982
left a comment
trangdoan982
left a comment
There was a problem hiding this comment.
lgtm for the main changes.
There was a problem hiding this comment.
oh i don't mind having it included in this PR. small change. thanks Sid
2 participants
Summary
Bulk identify ("bulk import") candidates now default to unselected in the Review Candidates step, per ENG-1685 / RES-120 ("During import, 'select all' should not be the default").
scanForBulkImportCandidates) and the fallback vault scan (fallbackScanVault), so the default is unselected regardless of which path runs.ImportNodesModal, "Import nodes from another space") has defaulted to unselected since its creation — this aligns the bulk identify modal with it.Fixes ENG-1685
🤖 Generated with Claude Code