Repository navigation
Keep extension prompts nonblocking - #75
Merged
Merged
Conversation
Unify command availability while keeping pending-input send admission local to each controller. Preserve queue access and drafts, and repair focus only when the prompt or dialog owned it. Cover project actions, Find, navigation, and asynchronous queue admission with deterministic regressions.
…t/f56b49ab-c5dc-45ff-a260-d1335ec1b23f
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
why do i can’t do some things (like collapse a project or rename it) when i have an active user action prompt (e.g. approve merge prompt from my custom extension)? this is backwards. it shouldn’t hijack the app’s functionality. the ONLY thing it should do is to hide the input composer and maybe hijack the focus. SIMPLIFY
Left unaddressed by your choice:
review: R1 · P2: Rename and settings completion leave focus on the body during a pending prompt
review: R2 · P2: Initially submitting prompts steal unrelated focus when submission fails
test: T1 · Transcript virtualization test intermittently cannot remount expanded row
test: T2 · WebKit startup blocks required cross-browser verification