Report argument mismatch details when no expectation matches by arguments - #353
Open
ChrisJr404 wants to merge 1 commit into
Open
Report argument mismatch details when no expectation matches by arguments#353ChrisJr404 wants to merge 1 commit into
ChrisJr404 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #158
When expectations are matched out of order and a call matches an expectation by its sql but not by its arguments, sqlmock skipped that expectation and only reported "was not expected", so there was no way to see why the arguments did not line up.
Ordered matching already returns the detailed "arguments do not match" error, which prints both the expected and the actual received values. This makes the unordered path do the same by remembering the closest argument mismatch and appending it to the error when nothing else matches.
Added a test covering both Exec and Query in unordered mode.