Skip to content

Rotation speed controller turn incorrectly when rotated #10863

Open

Description

@the-best-GPG

Description

A rotation speed controller if rotated either by a mechanical bearing or by having it in a schematic and rotating the schematic can have its rotation direction changed relative to parts connected to the receiving end.
This leads to the controller reversing its rotation direction and the connected machine to recive incorrect rotation and often malfunction. This can be observed in a lot of schematics that utilize rotation speed controller by rotating the schematic by 180 degrees or by simply placing a rotation speed controller in the world as it is only turning the correct way when looked at towards the north or west, if the controller is placed and looked at towards the south or east it will always rotate contrary to what selection of direction was made on the controller.

This causes the unnecessary need to manually adjust the rotation direction of a controller each time it is rotated meaning each time someone places a schematic containing a controller and dont place it in the exact same cardinal direction as the schematic was created in they have to adjust the rotation direction. In some cases where multiple rotation speed controllers are used if those contraptions are rotated the machine cant be fixed by just adjusting the rotation direction it would require to completely rebuild the machine.

I think i have a pretty good idea what causes the issue. The controller only saves its orientation as an "axis" variable (you can see it with F3) wich can only have one of two values z or x wich means the rotation speed controller determines wich side actually turns clockwise using the world axis.

This problem is also present for fluid valves by the way they also change their required rotation direction relative to the parts around them.

I have a video that proves the behaviour of the controller and the valve
https://youtu.be/vVx7f8BkneM
Create 6.0.10
Minecraft 1.21.1
NeoForge 21.1.265
I just tested it and Forge and Fabric on the 1.20.1 they have the same problem.

I made a schematic that showcases this:
https://createmod.com/schematics/rotation_speed_controllers_are_buggy-v3

Sable ( used by Create: Aeronautics) are working on a fix for this aswell:
ryanhcode/sable#1602

And i belive these PRs are linked to this one:
#3772
#1007
Creators-of-Aeronautics/Simulated-Project#968

Game Log

https://mclo.gs/hVsNbsE

Debug Information

Client Info
Create:
	Mod Version: 6.0.10
	Mod Git Commit: ac0c444d9828da3453ae8cc65338e8de063286fb
	Ponder Version: 1.0.82+mc1.21.1
	NeoForge Version: 21.1.265
	Minecraft Version: 1.21.1

Graphics:
	Flywheel Version: 1.0.6
	Flywheel Backend: flywheel:indirect
	OpenGL Renderer: AMD Radeon 780M Graphics
	OpenGL Version: 4.6.0 Core Profile Context 25.30.26.04.260320
	Graphics Mode: fancy
	PojavLauncher Detected: false

System Information:
	Operating System: Windows 11 (amd64) version 10.0
	Java Version: 21.0.13, Eclipse Adoptium
	JVM Flags: 4 total; -XX:HeapDumpPath=MojangTricksIntelDriversForPerformance_javaw.exe_minecraft.exe.heapdump -Xss1M -Xmx8000m -Xms256m
	Memory: 286810672 bytes (273 MiB) / 1241513984 bytes (1184 MiB) up to 8388608000 bytes (8000 MiB)
	Total Memory: 960991960 bytes (916 MiB) / 1241513984 bytes (1184 MiB)
	CPU: AMD Ryzen 7 8840U w/ Radeon 780M Graphics @ 3.29 GHz; 8 cores / 16 threads on 1 socket(s)
	Graphics cards: none

Other Mods:
Server Info
Create:
	Mod Version: 6.0.10
	Mod Git Commit: ac0c444d9828da3453ae8cc65338e8de063286fb
	Ponder Version: 1.0.82+mc1.21.1
	NeoForge Version: 21.1.265
	Minecraft Version: 1.21.1

System Information:
	Operating System: Windows 11 (amd64) version 10.0
	Java Version: 21.0.13, Eclipse Adoptium
	JVM Flags: 4 total; -XX:HeapDumpPath=MojangTricksIntelDriversForPerformance_javaw.exe_minecraft.exe.heapdump -Xss1M -Xmx8000m -Xms256m
	Memory: 286810672 bytes (273 MiB) / 1241513984 bytes (1184 MiB) up to 8388608000 bytes (8000 MiB)
	Total Memory: 960991960 bytes (916 MiB) / 1241513984 bytes (1184 MiB)
	CPU: AMD Ryzen 7 8840U w/ Radeon 780M Graphics @ 3.29 GHz; 8 cores / 16 threads on 1 socket(s)
	Graphics cards: none

Other Mods:

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    type: bugIssue where something isn't working

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions