Skip to content

Remove unused clipboardy dependency and orphaned CLI storage - #79

Merged
Coteh merged 4 commits into
mainfrom
claude/remove-clipboardy-dependency-uod1iv
Aug 26, 2026
Merged

Coteh merged 4 commits into
mainfrom
claude/remove-clipboardy-dependency-uod1iv

Conversation

@Coteh

@Coteh Coteh commented Aug 25, 2026

Copy link
Copy Markdown
Owner

Summary

  • Removed the unused clipboardy dependency from package.json (it wasn't imported anywhere in src), along with its now-orphaned transitive deps (is-wsl/is-dockerarch and execa stayed since cypress and jest still need them).
  • Removed CLIGameStorage (src/storage/cli.ts) and its test suite (test/cli_storage_test.ts) — no CLI entry point exists or is planned for this game. Also removed the memfs devDependency and the __mocks__/fs.js Jest mock, which existed only to support that test.
  • Excluded pnpm-lock.yaml from prettier (.prettierignore) — prettier's YAML printer reformats the lockfile into a different style than pnpm's own writer uses, so a pnpm run format pass was silently drifting the file out of pnpm's canonical format every time it ran.
  • Removed the README's "Wishlist (Not Started)" section (CLI interface, landscape mode, sound effects) since none of those are planned anymore.

Test plan

  • pnpm install --frozen-lockfile passes
  • pnpm run type-check passes
  • pnpm run lint passes (one pre-existing, unrelated warning)
  • pnpm run test-ci passes (34/34, down from 48 after removing the 14 CLI storage tests)
  • pnpm run format:check passes

Summary by CodeRabbit

  • Chores

    • Updated formatting exclusions to prevent lockfile formatting changes.
    • Removed unused development tooling and filesystem mocks.
  • Refactor

    • Removed command-line file storage for game data and preferences.
    • Removed associated automated tests.
  • Documentation

    • Updated project guidance for commit messages.
    • Removed outdated wishlist items and references to unimplemented CLI, landscape mode, and sound effects features.

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Aug 25, 2026

Copy link
Copy Markdown

Deploying 2048-clone with  Cloudflare Pages  Cloudflare Pages

Latest commit: 5d3dfd5
Status: ✅  Deploy successful!
Preview URL: https://f6e6b8c7.2048-clone-33h.pages.dev
Branch Preview URL: https://claude-remove-clipboardy-dep.2048-clone-33h.pages.dev

View logs

@coderabbitai

coderabbitai Bot commented Aug 25, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: a6ec5170-e333-447e-bdad-550a27e8c712

📥 Commits

Reviewing files that changed from the base of the PR and between 306220f and 4f33d4d.

📒 Files selected for processing (2)
  • CLAUDE.md
  • README.md
💤 Files with no reviewable changes (1)
  • README.md

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The change removes CLI file storage and its test suite, removes unused filesystem and clipboard dependencies, excludes pnpm-lock.yaml from Prettier processing, updates commit guidance, and removes obsolete README wishlist entries.

Changes

Repository cleanup

Layer / File(s) Summary
CLI storage removal
src/storage/cli.ts, test/cli_storage_test.ts, __mocks__/fs.js
Removes CLIGameStorage, its JSON file operations, the CLI storage tests, and the filesystem mock.
Formatting and dependency cleanup
.prettierignore, package.json
Adds pnpm-lock.yaml to Prettier ignores. Removes memfs and clipboardy from package configuration.
Repository guidance and README cleanup
CLAUDE.md, README.md
Documents commit message trailer rules and removes the obsolete wishlist section and related entries.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to 4f33d

This change removes unused dependencies, orphaned CLI storage, and outdated documentation while preserving the existing application behavior; the reported checks pass, and no actionable merge-blocking risk remains.

Poem

A rabbit clears the storage lane,

Lockfiles skip the formatter’s rain.
Old dependencies fade,
Commit rules are neatly laid,
The README hops clean again.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the two primary changes: removal of the unused clipboardy dependency and deletion of the orphaned CLI storage implementation and tests.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch claude/remove-clipboardy-dependency-uod1iv

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@Coteh Coteh changed the title Remove unused clipboardy dependency Remove unused clipboardy dependency and orphaned CLI storage Aug 25, 2026
coderabbitai[bot]
coderabbitai Bot previously approved these changes Aug 25, 2026
claude added 3 commits August 25, 2026 05:45
clipboardy wasn't imported anywhere in src. Also removed its
now-orphaned transitive deps (is-wsl, is-docker) from the lockfile,
and added a comment on CLIGameStorage clarifying it's kept for a
future CLI front-end rather than being dead code.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Not planning a CLI front-end for this game, so drop the unused
CLIGameStorage implementation, its test suite, and the memfs
devDependency and jest fs mock that only existed to support it.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
prettier reformats the lockfile's YAML into a different style than
pnpm's own writer uses (multi-line resolution blocks vs. pnpm's
compact single-line style), so running pnpm run format after any
pnpm install churns the whole file. *.yml was already ignored but
pnpm-lock.yaml uses the .yaml extension and slipped through.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@github-actions

github-actions Bot commented Aug 25, 2026

Copy link
Copy Markdown

Test Results

 14 files  ± 0   44 suites   - 1   2m 45s ⏱️ -6s
159 tests  - 14  159 ✅  - 13  0 💤 ±0  0 ❌  - 1 
167 runs   - 14  167 ✅  - 13  0 💤 ±0  0 ❌  - 1 

Results for commit 5d3dfd5. ± Comparison against base commit fced766.

This pull request removes 14 tests.
CLI storage game state should clear progress ‑ CLI storage game state should clear progress
CLI storage game state should load default values if no previous state was stored ‑ CLI storage game state should load default values if no previous state was stored
CLI storage game state should load progress ‑ CLI storage game state should load progress
CLI storage game state should save progress ‑ CLI storage game state should save progress
CLI storage persistent game state should clear persistent game state ‑ CLI storage persistent game state should clear persistent game state
CLI storage persistent game state should load default values if no previous state was stored ‑ CLI storage persistent game state should load default values if no previous state was stored
CLI storage persistent game state should load persistent game state ‑ CLI storage persistent game state should load persistent game state
CLI storage persistent game state should save persistent game state ‑ CLI storage persistent game state should save persistent game state
CLI storage preferences can clear preferences ‑ CLI storage preferences can clear preferences
CLI storage preferences can handle loading invalid state ‑ CLI storage preferences can handle loading invalid state
…

♻️ This comment has been updated with latest results.

CLI interface, landscape mode, and sound effects were listed as
not-started wishlist items; no longer planned, so drop the section
rather than leave stale scope in the docs.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
coderabbitai[bot]
coderabbitai Bot previously approved these changes Aug 25, 2026
@Coteh
Coteh force-pushed the claude/remove-clipboardy-dependency-uod1iv branch from 4f33d4d to 5d3dfd5 Compare August 25, 2026 13:36
@Coteh
Coteh merged commit a431847 into main Aug 26, 2026
8 checks passed

This branch was successfully deployed

1 active deployment
preview 5d3dfd58 Deployed Aug 25, 2026 by github-actions[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants