Remove unused clipboardy dependency and orphaned CLI storage - #79
Conversation
Deploying 2048-clone with
|
| Latest commit: |
5d3dfd5
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://f6e6b8c7.2048-clone-33h.pages.dev |
| Branch Preview URL: | https://claude-remove-clipboardy-dep.2048-clone-33h.pages.dev |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
💤 Files with no reviewable changes (1)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe change removes CLI file storage and its test suite, removes unused filesystem and clipboard dependencies, excludes ChangesRepository cleanup
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to This change removes unused dependencies, orphaned CLI storage, and outdated documentation while preserving the existing application behavior; the reported checks pass, and no actionable merge-blocking risk remains. Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Full details: Docstring CoverageExplanation No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.) ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
clipboardy wasn't imported anywhere in src. Also removed its now-orphaned transitive deps (is-wsl, is-docker) from the lockfile, and added a comment on CLIGameStorage clarifying it's kept for a future CLI front-end rather than being dead code. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Not planning a CLI front-end for this game, so drop the unused CLIGameStorage implementation, its test suite, and the memfs devDependency and jest fs mock that only existed to support it. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
prettier reformats the lockfile's YAML into a different style than pnpm's own writer uses (multi-line resolution blocks vs. pnpm's compact single-line style), so running pnpm run format after any pnpm install churns the whole file. *.yml was already ignored but pnpm-lock.yaml uses the .yaml extension and slipped through. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
306220f to
288b079
Compare
Test Results 14 files ± 0 44 suites - 1 2m 45s ⏱️ -6s Results for commit 5d3dfd5. ± Comparison against base commit fced766. This pull request removes 14 tests.♻️ This comment has been updated with latest results. |
CLI interface, landscape mode, and sound effects were listed as not-started wishlist items; no longer planned, so drop the section rather than leave stale scope in the docs. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
4f33d4d to
5d3dfd5
Compare
Summary
clipboardydependency frompackage.json(it wasn't imported anywhere insrc), along with its now-orphaned transitive deps (is-wsl/is-docker—archandexecastayed since cypress and jest still need them).CLIGameStorage(src/storage/cli.ts) and its test suite (test/cli_storage_test.ts) — no CLI entry point exists or is planned for this game. Also removed thememfsdevDependency and the__mocks__/fs.jsJest mock, which existed only to support that test.pnpm-lock.yamlfrom prettier (.prettierignore) — prettier's YAML printer reformats the lockfile into a different style than pnpm's own writer uses, so apnpm run formatpass was silently drifting the file out of pnpm's canonical format every time it ran.Test plan
pnpm install --frozen-lockfilepassespnpm run type-checkpassespnpm run lintpasses (one pre-existing, unrelated warning)pnpm run test-cipasses (34/34, down from 48 after removing the 14 CLI storage tests)pnpm run format:checkpassesSummary by CodeRabbit
Chores
Refactor
Documentation