Repository navigation
Small task, People and Activity fixes from the last organizations re-test - #1709
Merged
Merged
Conversation
INITIAL_ADMIN_EMAILS names the admins of the deployment's first organization and of no other, but every organization's People page said "Addresses in INITIAL_ADMIN_EMAILS are always admins. You can't change them here." The line now shows only while the person is working in the first organization. Test: admin-people-remove.test.tsx, the line shows in the first organization and not in another (shown in both before).
The needs-you line in the conversation that asked said "You answered this in its thread" even when the answer came from the Bots page's Needs you board. The card can't tell where the answer was given, so it no longer says.
Allow or Deny on the Needs you board left the sidebar badge on its old count until its next poll, seconds after the board showed the new one. Deciding an approval now reads the badge again at once, as answering a question already did.
…t can help A task card in the conversation that asked repeated the reason its failure line under it already gives, with the next step. The card now says Couldn't finish and leaves the reason to that line. Tasks gain canTryAgain: false when the task couldn't finish for a reason asking again gets the same answer to, such as a Bot it asked that isn't shared with the person. The Needs you board and the Activity rows then offer Open and Mark done, not Try again. The board also names the state as the card does, Couldn't finish, with the reason as its line.
With the reason said once, on the line a failed task reports, the card says only Couldn't finish. A task whose admin dismissed the Request access it waited on has no such line: its result was already said, with the app's card under it, and the result's link still read as done. The result now says why under its link ("Couldn't finish An admin didn't give this Bot Slack."), and the link reads as failed.
Test: task-thread.test.tsx, a result whose task then couldn't finish says why once and doesn't read as done (link read done, reason nowhere, before).
Activity named a Bot's owner switching an app on for their own Bot "Share an app", and off "Stop sharing an app". Nothing was shared with anybody. The rows now read "Give a Bot an app" and "Take an app from a Bot". Test: audit-event-words.test.tsx, the owner's on and off rows read as giving and taking (Share an app before).
An owner's Admin switch read off and greyed: the switch read role === "admin", and an owner's role is owner. An owner governs the organization as an admin does, so the switch now reads on, and it can't be changed there, nor is Remove offered: only an owner gives ownership away, in Organization settings, and the server keeps the owner. Test: admin-people-roles.test.tsx, an owner's switch reads on, can't be changed, and sends nothing (off before).
davidmckayv
requested review from
MikeRyanDev,
dustywusty,
guidovizoso,
mxmzb,
samjulien and
tylerslaton
as code owners
November 16, 2026 08:23
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small faults the last re-test of organizations found in the app, each fixed with a test that failed before the fix.
canTryAgain: false. The Needs you board then offers Open and Mark done, and names the state Couldn't finish, as the card does. A server that doesn't send the field still shows Try again.Tests: task-thread, needs-you, bots-nav-badge, admin-people-remove, admin-people-roles, audit-event-words. Screens checked in Chromium and WebKit, light and dark, at 1440 and 700.