fix(agent-runtime): keep MCP schemas JSON-serializable#877
Open
fortissolucoescontato-bit wants to merge 1 commit into
Open
Conversation
Store MCP tool input schemas as plain JSON Schema objects instead of converting them to Zod schemas before storage. Zod schemas contain circular internal references that cause JSON.stringify to fail with 'cannot serialize cyclic structures' when the agent state is serialized. The runtime now preserves the original JSON Schema and converts through ensureZodSchema only at the consumption boundary (getToolSet). Tests: 16 new tests covering schema storage, serialization roundtrip, multi-server scenarios, circular rejection defense, and full pipeline validation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Keeps MCP tool input schemas as plain JSON Schema objects while they are stored
in the agent runtime.
Previously, MCP input schemas were converted to Zod schemas before storage.
Those Zod instances contain circular internal references and could reach a
JSON.stringify boundary, causing normal Freebuff prompts to fail with:
JSON.stringify cannot serialize cyclic structuresThe runtime now preserves the original JSON Schema and converts through
ensureZodSchemaonly at the point where schema consumption or validation isrequired.
Behavior
ensureZodSchemaingetToolSet)Verification
Note
This PR is independent from the read-only
/mcpstatus command in PR #876.