Skip to content

fix(rs): validate function name in gateway deploy CLI #639

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
anupamme wants to merge 1 commit into from
Closed

fix(rs): validate function name in gateway deploy CLI #639

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions gateway/logic/clouds/redshift/cli.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -341,6 +341,9 @@ def deploy_external_function(
package_version: Package version for @@PACKAGE_VERSION@@ template variable
max_batch_rows: Maximum rows per Lambda batch invocation
"""
if not validate_sql_identifier(function_name, "function name"):
logger.error(f"Invalid function name '{function_name}'. Aborting for security.")
sys.exit(1)
# Render SQL template
renderer = TemplateRenderer()
sql = renderer.render_external_function(
Expand Down
Loading