Conversation
Match input allocations and reference outputs by captured allocation pointer and memory space. Expose allocation descriptors for unambiguous comparisons, including flat views whose extent is inferred from the recorded byte count. Reject ambiguous label-only lookups and cover duplicate labels, reordered references, empty allocations, and comparison size validation.
Signed-off-by: daxmawal <jeanfrancoismanutea@gmail.com>
daxmawal
commented
Sep 12, 2026
| const SnapshotAllocation& snapshot) { | ||
| // The captured allocation pointer includes its Kokkos header, so empty | ||
| // allocations remain distinct even when their data pointers are null. | ||
| return std::find_if( |
Member
Author
There was a problem hiding this comment.
I compared the current implementation with a temporary hash-index prototype. Results below are median times over 11 samples, using GCC 13 with -O3 on an Intel Core i9-13950HX.
| Allocations | Current implementation (µs) | With index (µs) |
|---|---|---|
| 16 | 0.55 | 1.21 |
| 64 | 2.53 | 4.67 |
| 256 | 18.98 | 19.63 |
| 1,024 | 242.86 | 108.04 |
| 4,096 | 4,263.91 | 375.43 |
| 16,384 | 69,257.30 | 1,981.76 |
The vector is faster for small allocation counts, while the index helps with larger captures.
Signed-off-by: daxmawal <jeanfrancoismanutea@gmail.com>
Signed-off-by: daxmawal <jeanfrancoismanutea@gmail.com>
daxmawal
marked this pull request as ready for review
September 14, 2026 13:49
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Kokkos allocations can share the same label. Previously, replay allocations and reference outputs were indexed by label, so one allocation could hide another and make output comparison unreliable. This change preserves each allocation separately and matches inputs with their reference outputs using the captured allocation pointer and memory space. The new
get_allocationsAPI exposes these pairs throughReplayAllocationdescriptors. Newcompare_viewsoverloads accept a descriptor and support explicit dimensions or a flat view whose size is inferred from the recorded byte count.Label-only lookups report an error when the label is ambiguous.
Tests cover duplicate labels, reordered references, empty allocations, and comparison size validation.
P.S. I encountered this issue in a Dyablo Kokkos kernel where multiple views shared the same label.