Addressing #1670: Settings reset upon new files only if the fields are incompatible#1683
Addressing #1670: Settings reset upon new files only if the fields are incompatible#1683glstott wants to merge 6 commits into
Conversation
…ded regression tests to check for custom node color preserved upon file changes.
…d is still exists before resetting the setting that uses it. So if a user deletes a node file with "state" and adds a node file with "state", if coloring of nodes used state, it will stay. If a user deletes this file, but doesn't add a replacement, it will then reset that setting.
# Conflicts: # cypress/e2e/ingestion/files-ui.cy.ts
|
I think this needs revisiting. It addresses the issue but reintroduces another one. |
|
Ok! I can remove that part. It was an intentional choice because they said it should reset only when a user starts a new session, not when deleting or adding files to the same session. |
|
Maybe we should add it to discussion for the meeting tomorrow. In my view, removing all the files would constitute the start of a new session, but maybe they have a different view. |
… update and update+reset buttons to the files tab.
This addresses bug #1670.
I've implemented a fix so that adding/removing files no longer resets user settings. Now, settings are reset when starting a new session or when a setting requires a field no longer included in the dataset. If a file is replaced with a compatible one, settings will stay. If a file is deleted that is needed, the setting will reset.
In the future, users may want an undo button, so I'll add a new issue to keep track of this ask.
Summary
Verification