Skip to content

Fix Edit tab top bar growing taller with long translations (BL-16834) #8334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
StephenMcConnel merged 1 commit into from
Sep 9, 2026
Merged

Fix Edit tab top bar growing taller with long translations (BL-16834) #8334

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 12 additions & 3 deletions src/BloomBrowserUI/react_components/BookSettingsButton.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,13 +38,22 @@ export const BookSettingsButton: React.FunctionComponent = (props) => {
textColor={kTextOnPurple}
disabledTextColor={kDisabledTextOnPurple}
cssOverrides={css`
width: 88px;
// The label wraps, and the TopBar is only as tall as its tallest child, so a
// label that wraps to three lines makes the whole bar taller (BL-16834, with
// the French "Paramètres du Livre et de la Page"). Let the button widen enough
// for long translations to fit on two lines, and clamp the label to two lines
// regardless so no translation can ever change the bar's height.
min-width: 88px;
max-width: 124px;
white-space: normal;
line-height: 1.15;

span {
display: inline-block;
max-width: 72px;
display: -webkit-box;
-webkit-box-orient: vertical;
-webkit-line-clamp: 2;
overflow: hidden;
max-width: 108px;
}

// Recolor the (solid black) icon to black at 80% opacity so it matches
Expand Down