BL-16818 Tables 4/6: the e2e step caption, and test ids - #8328
Open
hatton wants to merge 2 commits into
Open
Conversation
Fourth of six PRs splitting BL-16818. This is the only production code in the end-to-end half of that work, split out so that it gets read rather than skimmed past several thousand lines of test code. None of it is about tables. The step caption is a strip the workspace shell shows only under --e2e, naming the step a test is on. Watching a run without it is watching Bloom do things for no stated reason; with it, a recording explains itself. CommonApi reports runningE2eTests so the shell knows whether to mount it. The rest is test ids on three places where the only other handle is a localized label: the subscription dialog, the higher-tier publish notice, and the toolbox tool checkboxes. The add-e2e-test skill gains a section on what a gated feature's test plan owes a non-subscriber. Subscribers make books; the people who reuse them, above all to translate them, often have no subscription, and must still be able to localize what is there.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fourth of six stacked PRs splitting #8315. Base is
BL-16818-table-video-cells(#8327).This is the only production code in the end-to-end half of that work, split out so that it gets read rather than skimmed past several thousand lines of test code. None of it is about tables.
The step caption is a strip the workspace shell shows only under
--e2e, naming the step a test is on. Watching a run without it is watching Bloom do things for no stated reason; with it, a recording explains itself.CommonApireportsrunningE2eTestsso the shell knows whether to mount it.Test ids on three places where the only other handle is a localized label: the subscription dialog, the higher-tier publish notice, and the toolbox tool checkboxes.
The
add-e2e-testskill gains a section on what a gated feature's test plan owes a non-subscriber. Subscribers make books; the people who reuse them, above all to translate them, often have no subscription, and must still be able to localize what is there. Worth reading on its own — it applies to every gated feature, not just tables.Note for reviewers: the version of this work on #8315 also carried an
ExperimentalFeaturesenvironment variable and anextVideoFileToChooseendpoint. Both were superseded onmasterby the--experimental-featurescommand line and the generalnextFileToChoose, so neither is here.Checks
pnpm typecheck, the caption's own 17 tests,build/agent-vite.sh, and aBloomExebuild all green.[Claude Opus 5 following a prompt from Hatton]
Devin review
This change is