Skip to content

[codex] Stabilize Modulate STT unit tests on Windows#7942

Open
tianmind-studio wants to merge 1 commit into
BasedHardware:mainfrom
tianmind-studio:codex/windows-modulate-websockets-stub
Open

[codex] Stabilize Modulate STT unit tests on Windows#7942
tianmind-studio wants to merge 1 commit into
BasedHardware:mainfrom
tianmind-studio:codex/windows-modulate-websockets-stub

Conversation

@tianmind-studio

@tianmind-studio tianmind-studio commented Jun 14, 2026

Copy link
Copy Markdown
Contributor

Summary

  • stub websocket/prometheus/heavy imports so test_modulate_stt.py can collect on Windows without installing optional realtime STT dependencies
  • keep Modulate socket close tests from waiting on the receive loop during mocked cancellation
  • update prerecorded routing patches for the current stt_prerecorded_models list setting
  • make the action-item test stubs reuse existing packages and attach child modules so collecting it after Modulate does not remove utils.stt from the parent package

Review follow-up

  • Removed the previous Parakeet WebSocket runtime auth-header change. This PR is now test-only and no longer sends ENCRYPTION_SECRET to the Parakeet service.
  • Current head: 4b198e757f.

Validation

  • python -m pytest backend\\tests\\unit\\test_modulate_stt.py -q --tb=short -> 91 passed
  • python -m pytest backend\\tests\\unit\\test_action_item_date_validation.py backend\\tests\\unit\\test_modulate_stt.py -q --tb=short -> 117 passed
  • python -m pytest backend\\tests\\unit\\test_modulate_stt.py backend\\tests\\unit\\test_action_item_date_validation.py -q --tb=short -> 117 passed
  • python -m py_compile backend\\tests\\unit\\test_modulate_stt.py backend\\tests\\unit\\test_action_item_date_validation.py backend\\utils\\stt\\streaming.py
  • python -m black --line-length 120 --skip-string-normalization --check backend\\tests\\unit\\test_modulate_stt.py backend\\tests\\unit\\test_action_item_date_validation.py backend\\utils\\stt\\streaming.py
  • git diff --check origin/main...HEAD
  • scripts/pre-commit with the backend venv on PATH

@kodjima33 kodjima33 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Backend (stabilize Modulate STT tests; touches streaming.py) — approve only per policy.

@tianmind-studio tianmind-studio force-pushed the codex/windows-modulate-websockets-stub branch from f64925c to 241eb08 Compare June 16, 2026 15:22
@ThomsenDrake

Copy link
Copy Markdown
Collaborator

ClawSweeper local pilot review

Recommendation: keep open, but do not merge as-is.

What it found:

  • The Windows test-stabilization goal is useful.
  • The runtime change sends ENCRYPTION_SECRET as outbound Parakeet WebSocket authorization. That secret is the backend data-encryption master secret.
  • Current Parakeet /v3/stream behavior does not validate that header, so this broadens secret exposure without creating an enforced auth boundary.
  • The streaming auth contract is also missing docs, and proof is mock-only.

Suggested next step: use a dedicated Parakeet service credential with server-side validation, update tests/charts/docs for that contract, or keep this PR test-only.

Posted from a local report-only ClawSweeper pilot by request; no labels, closes, repairs, or merges were performed.

Stub optional import-time dependencies so test_modulate_stt can collect in lightweight Windows backend environments.

Keep drain ordering tests from waiting for provider done messages, update prerecorded model patches to the current list setting, and pass the configured Parakeet WebSocket auth header.
@tianmind-studio tianmind-studio force-pushed the codex/windows-modulate-websockets-stub branch from 241eb08 to 4b198e7 Compare June 17, 2026 00:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants