[codex] Harden Windows memory dump parsing#7900
Open
tianmind-studio wants to merge 2 commits into
Open
Conversation
9ae6660 to
0a9fc65
Compare
0a9fc65 to
1d014a7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
Windows users often copy memory lists from chat surfaces that wrap content in Markdown fences or use typographic bullets/dashes. The existing parser could keep ``` fences as bogus memories and leave some common marker characters in the imported text.
Refresh
mainat1a5824403b.1d014a789c.Validation
vitest run src/main/memoryImport/parse.test.ts-> 1 file passed, 8 tests passednpm run typecheck-> passedprettier --check src/main/memoryImport/parse.ts src/main/memoryImport/parse.test.ts-> passedgit diff --check origin/main...HEADscripts/pre-commitwith the backend Windows venv and local Dart SDK onPATH