Repository navigation
Update DisableADAccountsMenu to include new accounts - #91
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
Updates the DisableADAccountsMenu function to replace existing user accounts with new ones. The PR changes the hardcoded user accounts from Kurtis Marsden, Jamie Beale, and Luke Leigh to John Smith, Jack Daniels, and Geoff Geoffries.
- Replaces three existing user account functions with new user account functions
- Updates menu display text to reflect the new account names
- Updates switch statement cases to call the new functions
Comment on lines
+38
to
41
| function Disable-JohnSmith { | ||
| Disable-ADAccount -Identity JohnSmith.admin | ||
| Write-Output "Account JohnSmith.admin has been disabled." | ||
| } |
There was a problem hiding this comment.
Hardcoding specific user accounts in a function creates maintenance overhead. Consider making this function more generic by accepting user identities as parameters, or using a configuration file to define the accounts that can be disabled.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.