feat: add support for nested virtualization detection - #41
Merged
Matthew Christopher (matthchr) merged 1 commit intoAug 31, 2026
Merged
Conversation
Maximiliano Uribe Falcon (MaximilianoUribe)
approved these changes
Aug 31, 2026
Alex Leites (tallaxes)
approved these changes
Aug 31, 2026
|
Nothing in the resource API to reflect this? |
Bevan Arps (theunrepentantgeek)
approved these changes
Aug 31, 2026
Bevan Arps (theunrepentantgeek)
left a comment
Bevan Arps (theunrepentantgeek)
left a comment
Member
There was a problem hiding this comment.
It occurred to me that you could potentially merge some of these together, e.g.
regexp.MustCompile(`^standard_d\d+s?_v[345]$`)
But on reflection I don't think it would add to readability or maintainability.
#lgtm
Matthew Christopher (matthchr)
deleted the
matthchr/nested-virtualization
branch
August 31, 2026 21:41
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note that this duplicates logic in AKS RP and I will update AKS RP to use this going forward.