Skip to content

Ignore putStream content-length requirement when transfer-encoding is chunked - #323

Open
ccorcos wants to merge 1 commit into
Automattic:masterfrom
ccorcos:master
Open

Ignore putStream content-length requirement when transfer-encoding is chunked#323
ccorcos wants to merge 1 commit into
Automattic:masterfrom
ccorcos:master

Conversation

@ccorcos

@ccorcos ccorcos commented Jun 2, 2017

Copy link
Copy Markdown

#322 @TooTallNate @rauchg

Now the following code works:

const request = require("request")

request.get(url)
	.on("response", (res) => {
		const req = client.putStream(res, "some/path", res.headers, function (err, res) {
			console.log(err, req.url)
		})
	})

@ccorcos

ccorcos commented Jun 2, 2017

Copy link
Copy Markdown
Author

Wait a second... I'm getting a 501 Not Implemented response...

@ccorcos

ccorcos commented Jun 2, 2017

Copy link
Copy Markdown
Author

Looks like this might be a better option for me: https://github.com/nathanpeck/s3-upload-stream

@devpascoe

Copy link
Copy Markdown

@ccorcos i tried that s3-upload-stream package too on a chunked stream i wanted to upload directly to s3 and its callback never ... called back. Tried all the libraries. How has no one run into this issue before?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants