fix: implement TextInputClient.onFocusReceived for Flutter >= 3.44 compatibility - #1226
Open
al-the-bear wants to merge 1 commit into
Open
fix: implement TextInputClient.onFocusReceived for Flutter >= 3.44 compatibility#1226al-the-bear wants to merge 1 commit into
al-the-bear wants to merge 1 commit into
Conversation
Flutter 3.44 added `TextInputClient.onFocusReceived` (a concrete member with a `=> false` default on the `TextInputClient` mixin). Because `DeltaTextInputClient` only *implements* `TextInputClient`, the default body does not carry over to `DeltaTextInputService`, so on Flutter >= 3.44 the class no longer satisfies the interface and fails to compile: Missing concrete implementation of 'TextInputClient.onFocusReceived'. Provide the override, matching the framework default (`=> false`), so the editor builds against Flutter 3.44+ while remaining a no-op on older versions where the member is simply unused.
|
al-the-bear seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
On Flutter 3.44+,
appflowy_editorfails to compile with:Flutter 3.44 added
TextInputClient.onFocusReceived()— a concrete member with a=> falsedefault on theTextInputClientmixin (packages/flutter/lib/src/services/text_input.dart).DeltaTextInputServicemixes inDeltaTextInputClient, which only implementsTextInputClient; the framework's default body does not carry over to animplementsrelationship, so the concrete class no longer satisfies the interface.Fix
Add the
onFocusReceivedoverride toDeltaTextInputService, matching the framework default (=> false). It is a no-op on older Flutter versions where the member is unused, and restores compilation on 3.44+.Notes