Repository navigation
fix(Icon Button): Draw the contrast hover background from the text colour - #3004
Merged
Merged
Conversation
github-actions
Bot
temporarily deployed
to
demo-icon-button-contrast-hover-color
October 2, 2026 14:25
Destroyed
Contributor
Coverage Report for React components
File CoverageNo changed files found. |
Contributor
|
Size Change: +2 B (0%) Total Size: 428 kB 📦 View Changed
ℹ️ View Unchanged
|
RubenSibon
approved these changes
Oct 9, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the pull request
Links
What
Change the background of a hovered contrast Icon Button from
rgb(0 0 0 / 12.5%)torgb(32 32 32 / 12.5%).Why
The 12.5% transparency must be drawn from the text colour,
#202020, not from pure black.How
A token cannot apply an alpha to another token, so the value is a literal, like the hover background of the default Icon Button.
This was the only pure black in the default theme's tokens.
We probably did not find it earlier because it is written as
rgb()with an alpha, while every other colour is a hex value.Checklist
Before submitting your pull request, please ensure you have done the following. Check each checkmark if you have done so or if it wasn't necessary:
/chromatic testand verify visual regression tests pass