[PWGLF] Modify K* task for mixed-event v2 extraction in kstarpbpb.cxx by sarjeetagami · Pull Request #16906 · AliceO2Group/O2Physics

sarjeetagami · 2026-07-02T16:55:34Z

No description provided.

github-actions · 2026-07-02T16:55:54Z

O2 linter results: ❌ 0 errors, ⚠️ 0 warnings, 🔕 0 disabled

vkucera · 2026-07-02T17:14:32Z

@sarjeetagami Please fix the name of you repository. It's blocking the creation of the automatic formatting PR.

alibuild · 2026-07-03T07:23:53Z

Error while checking build/O2Physics/staging for 3df9ba9 at 2026-07-03 09:23:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGLF/Tasks/Resonances/kstarpbpb.cxx:779:12: error: unused variable 'centrality2' [-Werror=unused-variable]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGLF/Tasks/Resonances/kstarpbpb.cxx:1009:22: error: variable 'eventplaneVecRec' set but not used [-Werror=unused-but-set-variable]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGLF/Tasks/Resonances/kstarpbpb.cxx:1076:18: error: variable 'eventplaneVecGen' set but not used [-Werror=unused-but-set-variable]
ninja: build stopped: subcommand failed.

Full log here.

alibuild · 2026-07-03T07:26:05Z

Error while checking build/O2Physics/code-check for 3df9ba9 at 2026-07-03 09:26:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 10 errors and 7 warnings.'
Found 10 errors and 7 warnings.
++ [[ 10 -gt 0 ]]
++ cat /sw/BUILD/63b505c94773b10b723fd241f47150d17472d9c0/O2Physics-code-check/errors.txt
PWGLF/Tasks/Resonances/kstarpbpb.cxx:21:1: error: included header TriggerAliases.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGLF/Tasks/Resonances/kstarpbpb.cxx:53:1: error: included header TMath.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGLF/Tasks/Resonances/kstarpbpb.cxx:68:8: error: constructor does not initialize these fields: ccdb, v2, v2Rot, hweight [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
PWGLF/Tasks/Resonances/kstarpbpb.cxx:456:48: error: narrowing conversion from constant 'float' to 'unsigned int' [bugprone-narrowing-conversions,-warnings-as-errors]
PWGLF/Tasks/Resonances/kstarpbpb.cxx:464:14: error: redundant boolean literal in conditional return statement [readability-simplify-boolean-expr,-warnings-as-errors]
PWGLF/Tasks/Resonances/kstarpbpb.cxx:779:12: error: Value stored to 'centrality2' during its initialization is never read [clang-analyzer-deadcode.DeadStores,-warnings-as-errors]
PWGLF/Tasks/Resonances/kstarpbpb.cxx:779:12: error: unused variable 'centrality2' [clang-diagnostic-unused-variable,-warnings-as-errors]
PWGLF/Tasks/Resonances/kstarpbpb.cxx:958:15: error: boolean expression can be simplified by DeMorgan's theorem [readability-simplify-boolean-expr,-warnings-as-errors]
PWGLF/Tasks/Resonances/kstarpbpb.cxx:958:30: error: no header providing "PDG_t" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGLF/Tasks/Resonances/kstarpbpb.cxx:1172:15: error: boolean expression can be simplified by DeMorgan's theorem [readability-simplify-boolean-expr,-warnings-as-errors]
++ [[ 7 -gt 0 ]]
++ cat /sw/BUILD/63b505c94773b10b723fd241f47150d17472d9c0/O2Physics-code-check/warnings.txt
PWGLF/Tasks/Resonances/kstarpbpb.cxx:493:27: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Resonances/kstarpbpb.cxx:496:37: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Resonances/kstarpbpb.cxx:500:66: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Resonances/kstarpbpb.cxx:504:67: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Resonances/kstarpbpb.cxx:508:66: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Resonances/kstarpbpb.cxx:512:70: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Resonances/kstarpbpb.cxx:1218:59: warning: statement should be inside braces [readability-braces-around-statements]
++ [[ 10 -gt 0 ]]
++ exit 1
--

Full log here.

alibuild · 2026-07-03T08:21:54Z

Error while checking build/O2Physics/o2 for 3df9ba9 at 2026-07-03 10:21:

## sw/BUILD/O2Physics-latest/log
c++: fatal error: Killed signal terminated program cc1plus
ninja: build stopped: subcommand failed.

Full log here.

alibuild · 2026-07-03T12:52:50Z

Error while checking build/O2Physics/code-check for 4b8cf94 at 2026-07-03 14:52:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 8 errors and 0 warnings.'
Found 8 errors and 0 warnings.
++ [[ 8 -gt 0 ]]
++ cat /sw/BUILD/85c322bf7ef5ca7309cf7f963b2c5779b0b3507f/O2Physics-code-check/errors.txt
PWGLF/Tasks/Resonances/kstarpbpb.cxx:21:1: error: included header TriggerAliases.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGLF/Tasks/Resonances/kstarpbpb.cxx:53:1: error: included header TMath.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGLF/Tasks/Resonances/kstarpbpb.cxx:68:8: error: constructor does not initialize these fields: ccdb, v2, v2Rot, hweight [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
PWGLF/Tasks/Resonances/kstarpbpb.cxx:453:48: error: narrowing conversion from constant 'float' to 'unsigned int' [bugprone-narrowing-conversions,-warnings-as-errors]
PWGLF/Tasks/Resonances/kstarpbpb.cxx:461:14: error: redundant boolean literal in conditional return statement [readability-simplify-boolean-expr,-warnings-as-errors]
PWGLF/Tasks/Resonances/kstarpbpb.cxx:954:15: error: boolean expression can be simplified by DeMorgan's theorem [readability-simplify-boolean-expr,-warnings-as-errors]
PWGLF/Tasks/Resonances/kstarpbpb.cxx:954:30: error: no header providing "PDG_t" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGLF/Tasks/Resonances/kstarpbpb.cxx:1166:15: error: boolean expression can be simplified by DeMorgan's theorem [readability-simplify-boolean-expr,-warnings-as-errors]
++ [[ 0 -gt 0 ]]
++ [[ 8 -gt 0 ]]
++ exit 1
--

Full log here.

prottayCMT

Please correct the errors on code-check

alibuild · 2026-07-03T17:29:46Z

Error while checking build/O2Physics/code-check for 3549263 at 2026-07-03 19:29:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 1 errors and 0 warnings.'
Found 1 errors and 0 warnings.
++ [[ 1 -gt 0 ]]
++ cat /sw/BUILD/dec05d4fad965e4d90775d34f83a0506f2da25d6/O2Physics-code-check/errors.txt
PWGLF/Tasks/Resonances/kstarpbpb.cxx:21:1: error: included header RecoDecay.h is not used directly [misc-include-cleaner,-warnings-as-errors]
++ [[ 0 -gt 0 ]]
++ [[ 1 -gt 0 ]]
++ exit 1
--

Full log here.

sarjeetagami · 2026-07-04T08:53:22Z

Please correct the errors on code-check

@prottayCMT, @dmallick2, code checker issues have been fixed and all the required checks have passed. Could you please merge the PR? Thank you!

vkucera · 2026-07-04T13:11:16Z

@dmallick2 @prottayCMT Please be careful what you approve. There was an additional file committed by accident in the root directory of the repository.

prottayCMT · 2026-07-04T13:16:02Z

@dmallick2 @prottayCMT Please be careful what you approve. There was an additional file committed by accident in the root directory of the repository.

@vkucera yes u are right. Sorry that I overlooked it while approving

github-actions Bot added the pwglf label Jul 2, 2026

sarjeetagami force-pushed the master branch 2 times, most recently from b199f5b to e3a1847 Compare July 2, 2026 17:12

sarjeetagami force-pushed the master branch 2 times, most recently from ae13af0 to 3df9ba9 Compare July 3, 2026 06:47

sarjeetagami changed the title ~~[PWGLF] Modify K* task for mixed-event v2 extraction~~ [PWGLF] Modify K* task for mixed-event v2 extraction in kstarpbpb.cxx Jul 3, 2026

sarjeetagami marked this pull request as ready for review July 3, 2026 06:54

sarjeetagami requested review from a team, alibuild, ddobrigk, dmallick2, dsekihat, iarsene, jgrosseo, ktf, mpuccio, omvazque, prottayCMT, skundu692 and smaff92 as code owners July 3, 2026 06:54

sarjeetagami marked this pull request as draft July 3, 2026 08:20

sarjeetagami force-pushed the master branch from 3df9ba9 to 4b8cf94 Compare July 3, 2026 10:03

sarjeetagami marked this pull request as ready for review July 3, 2026 10:09

prottayCMT requested changes Jul 3, 2026

View reviewed changes

sarjeetagami force-pushed the master branch from 4b8cf94 to 3549263 Compare July 3, 2026 17:10

sarjeetagami force-pushed the master branch from 3549263 to 294559f Compare July 3, 2026 17:39

dmallick2 previously approved these changes Jul 3, 2026

View reviewed changes

dmallick2 enabled auto-merge (squash) July 3, 2026 19:41

dmallick2 disabled auto-merge July 4, 2026 09:04

dmallick2 enabled auto-merge (squash) July 4, 2026 09:04

prottayCMT previously approved these changes Jul 4, 2026

View reviewed changes

sarjeetagami marked this pull request as draft July 4, 2026 13:00

auto-merge was automatically disabled July 4, 2026 13:00
Pull request was converted to draft

[PWGLF] Modify K* task for mixed-event v2 extraction

6fbd1b6

sarjeetagami dismissed stale reviews from prottayCMT and dmallick2 via 6fbd1b6 July 4, 2026 13:08

sarjeetagami force-pushed the master branch from 294559f to 6fbd1b6 Compare July 4, 2026 13:08

sarjeetagami marked this pull request as ready for review July 4, 2026 13:14

prottayCMT enabled auto-merge (squash) July 4, 2026 14:01

prottayCMT approved these changes Jul 4, 2026

View reviewed changes

prottayCMT merged commit 3f60702 into AliceO2Group:master Jul 4, 2026
14 of 15 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[PWGLF] Modify K* task for mixed-event v2 extraction in kstarpbpb.cxx#16906

[PWGLF] Modify K* task for mixed-event v2 extraction in kstarpbpb.cxx#16906
prottayCMT merged 1 commit into
AliceO2Group:masterfrom
sarjeetagami:master

sarjeetagami commented Jul 2, 2026

Uh oh!

github-actions Bot commented Jul 2, 2026

Uh oh!

vkucera commented Jul 2, 2026

Uh oh!

alibuild commented Jul 3, 2026

Uh oh!

alibuild commented Jul 3, 2026

Uh oh!

alibuild commented Jul 3, 2026

Uh oh!

alibuild commented Jul 3, 2026

Uh oh!

prottayCMT left a comment

Uh oh!

alibuild commented Jul 3, 2026

Uh oh!

sarjeetagami commented Jul 4, 2026

Uh oh!

vkucera commented Jul 4, 2026

Uh oh!

prottayCMT commented Jul 4, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

5 participants

Uh oh!

Conversation

sarjeetagami commented Jul 2, 2026

Uh oh!

github-actions Bot commented Jul 2, 2026

Uh oh!

vkucera commented Jul 2, 2026

Uh oh!

alibuild commented Jul 3, 2026

Uh oh!

alibuild commented Jul 3, 2026

Uh oh!

alibuild commented Jul 3, 2026

Uh oh!

alibuild commented Jul 3, 2026

Uh oh!

prottayCMT left a comment

Choose a reason for hiding this comment

Uh oh!

alibuild commented Jul 3, 2026

Uh oh!

sarjeetagami commented Jul 4, 2026

Uh oh!

vkucera commented Jul 4, 2026

Uh oh!

prottayCMT commented Jul 4, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

5 participants