Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Primary-objective combo doesn't refresh on role changes
The Bayesian viewer's Primary-objective combo refreshed on add/remove/rename but
not when a row's Role changed (the role is a
QComboBoxcell-widget whosechanges were never wired up). Flipping an objective maximize→observe wrongly left
it in the Primary list.
_ObjectiveTablenow has anobjectives_changedsignal, emitted on any changeto the optimized set (cell edits, add, remove, role/protocol combo changes).
Rows are built under
blockSignalsso a half-built row can't fire a refresh.objectives_changed → _refresh_primary_combo.tests/unit/test_bayesian_primary_combo.py).Mask load: lossless transpose instead of downsampling resize
Loading a mask whose dimensions are simply swapped vs the detector (e.g. 100×400
on a 400×100 detector) only warned, then resampled it through skimage
resize,arriving badly downsampled.
load_mask_clickednow detects the pure axes-swap case(
mask.shape == img_shape[::-1]) and offers a lossless transpose that matchesthe detector at native resolution. Any other mismatch keeps the original
warn + resize behavior.