Add codeql yml file - #113
Merged
Merged
Conversation
Coverage Report
|
Drop the temporary `upload: never` used to validate the traced build while the code quality ruleset rule was still active. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
|
You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool. What Enabling Code Scanning Means:
For more information about GitHub Code Scanning, check out the documentation. |
mzielu
marked this pull request as ready for review
July 27, 2026 16:31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
This repo had no security code scanning. It had GitHub Code Quality, which runs as a dynamic workflow—no Gradle caching and not re-runnable.
On #106, the Gradle wrapper download timed out, and with the
code_qualityruleset rule gating merges, the only escape was:That blocking issue has already been fixed by a settings change (described below). This PR adds the missing security scanning as a real workflow file so it's cached and re-runnable.
What changed
Adds
.github/workflows/codeql.yml— CodeQL advanced setup forjava-kotlin.Triggers:
mastermasterKey configuration:
build-mode: manual— Kotlin can't be analyzed buildless.--no-build-cache --no-configuration-cacheare load-bearing. CodeQL builds its database by tracing the compiler. Sincegradle.propertiesenables both caches, a cachedcompileKotlinwould produce an empty database—a green check that analyzed nothing.setup-gradle@v4caches the Gradle distribution and adds a 3× retry for cold starts (addressing the chore(deps): bump jvm from 2.4.0 to 2.4.10 #106 failure).queries: security-extended— free on public repositories, with roughly 30–60% longer analysis time.Verified on this PR:
Code scanning results / CodeQLreports no new alerts.Settings changed outside this diff
code_qualityruleset rule — this was what allowed flaky runs to block merges. Quality findings no longer gate pull requests; GitHub only provides that gate through the non-rerunnable workflow.Follow-ups
code-qualityinto the workflow onceanalysis-kindsis no longer[Internal].package-ecosystem: github-actionstodependabot.yml(currently Gradle only).Unblocks #106.