🎨 Palette: Improve password toggle accessibility - #488
Conversation
Co-authored-by: 2fst4u <15257926+2fst4u@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
💡 What: Replaced dynamic
:aria-labelattributes on the three password visibility toggle buttons (login, current password, new password) with inner visually hidden<span class="sr-only">elements whose text updates dynamically via Alpine.js.🎯 Why: To ensure screen readers explicitly announce the active state dynamically ("Show password" vs. "Hide password") and to improve internationalization, as standard
aria-labelattributes are frequently ignored by automated translation tools.📸 Before/After: Visual layout remains completely unaffected.
♿ Accessibility: The active state of the icon-only toggle button is now robustly conveyed to screen readers and translation tools via actual DOM text content inside an
.sr-onlyspan.PR created automatically by Jules for task 4120395144574641318 started by @2fst4u